[SRU][P][PATCH 00/31] Enable AMD ACP70/ACP71 and relevant soundwire support

Yo-Jung (Leo) Lin leo.lin at canonical.com
Mon Mar 31 03:34:25 UTC 2025


BugLink: https://bugs.launchpad.net/bugs/2098457

[ Impact ]

This introduces support for the ACP70/ACP71 audio co-processors, as well
as soundwire related integration. The main patchesets are:

1. [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1
platforms[1]
2. [PATCH V4 0/6] soundwire: amd: code improvements and new platform
support[2]
3. [PATCH] ASoC: amd: ps: use switch statements for acp pci revision id
check[3]

As well as their dependent patches.

[1]
https://lore.kernel.org/alsa-devel/173946420611.270661.6294707599627839150.b4-ty@kernel.org/T/#mc726945cf0e97d7cbbc5a9dda3b33d42779ed3af
[2]
https://lore.kernel.org/alsa-devel/173920500520.65690.5365981028345549480.b4-ty@kernel.org/T/#m2d7a2b3b128813a2ee5fc45c8d31982c5f2d709c
[3]
https://lore.kernel.org/alsa-devel/173945697146.151957.15841988796176463409.b4-ty@kernel.org/T/#m778380541979c1bb1f8bf5863e8a30015289b067

[ Test ]

1. Test record/playback of built-in mic and speakers by, say, recording
and playing the speaker test sound in the gnome control center.
2. Connect to headphones and test playback and recording.
3. Suspend the machine and test 1. and 2. again.
4. Test the above 3 on a ACP63 machine.

[ Where the problems could occur ]

Most of the codes are AMD-specific. However, those patches contain
refactors to the existing ACP63 codes. Errors in those refactoring may
impact existing ACP63 platforms.

The patch "[PATCH V3 19/25] ASoC: amd: ps: update file description and
copyright year"[4] didn't get backported, because it used to conflicted 
due to the recent MODULE_IMPORT_NS() API change in cdd30ebb1b9f (module:
Convert symbol namespace to string literal). This patch only change the
module description and doesn't have real functional impact, so was not
pulled in.

[4]
https://lore.kernel.org/alsa-devel/173920500520.65690.5365981028345549480.b4-ty@kernel.org/T/#m39948f8b75ae43055b55a0ccc4dbec66de1eb269


Vijendar Mukunda (31):
  ASoC: amd: ps: rename structure names, variable and other macros
  ASoC: amd: ps: use macro for ACP6.3 pci revision id
  ASoC: amd: ps: add acp pci driver hw_ops for acp6.3 platform
  ASoC: amd: ps: add callback functions for acp pci driver pm ops
  ASoC: amd: ps: add callback to read acp pin configuration
  ASoC: amd: ps: add soundwire dma irq thread callback
  ASoC: amd: ps: refactor soundwire dma interrupt handling
  ASoC: amd: ps: store acp revision id in SoundWire dma driver private
    data
  ASoC: amd: ps: refactor soundwire dma driver code
  ASoC: amd: ps: refactor soundwire dma interrupts enable/disable
    sequence
  ASoC: amd: ps: rename acp_restore_sdw_dma_config() function
  ASoC: amd: ps: add pci driver hw_ops for ACP7.0 & ACP7.1 variants
  ASoC: amd: ps: add pm ops related hw_ops for ACP7.0 & ACP7.1 platforms
  ASoC: amd: ps: add ACP7.0 & ACP7.1 specific soundwire dma driver
    changes
  ASoC: amd: ps: implement function to restore dma config for ACP7.0
    platform
  ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0
    platform
  ASoC: amd: ps: add soundwire wake interrupt handling
  ASoC: amd: ps: update file description and copyright year
  ASoC: amd: update Pink Sardine platform Kconfig description
  ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1
    platforms
  ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform
  ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support
  ASoC: amd: acp: amd-acp70-acpi-match: Add RT1320 & RT722 combination
    soundwire machine
  ASoC: amd: amd_sdw: Add quirks for Dell SKU's
  soundwire: amd: change the soundwire wake enable/disable sequence
  soundwire: amd: add debug log for soundwire wake event
  soundwire: amd: add support for ACP7.0 & ACP7.1 platforms
  soundwire: amd: set device power state during suspend/resume sequence
  soundwire: amd: set ACP_PME_EN during runtime suspend sequence
  soundwire: amd: add soundwire host wake interrupt enable/disable
    sequence
  ASoC: amd: ps: use switch statements for acp pci revision id check

 drivers/soundwire/amd_manager.c          | 149 ++++++-
 drivers/soundwire/amd_manager.h          |  26 ++
 include/linux/soundwire/sdw_amd.h        |   2 +
 sound/soc/amd/Kconfig                    |  10 +-
 sound/soc/amd/acp/Kconfig                |   1 +
 sound/soc/amd/acp/Makefile               |   2 +-
 sound/soc/amd/acp/acp-sdw-legacy-mach.c  |  45 +++
 sound/soc/amd/acp/acp-sdw-mach-common.c  |  34 ++
 sound/soc/amd/acp/amd-acp70-acpi-match.c | 160 ++++++++
 sound/soc/amd/acp/soc_amd_sdw_common.h   |  12 +
 sound/soc/amd/mach-config.h              |   1 +
 sound/soc/amd/ps/Makefile                |   2 +-
 sound/soc/amd/ps/acp63.h                 | 246 ++++++++++--
 sound/soc/amd/ps/pci-ps.c                | 430 ++++++++++----------
 sound/soc/amd/ps/ps-common.c             | 475 +++++++++++++++++++++++
 sound/soc/amd/ps/ps-pdm-dma.c            |   4 +-
 sound/soc/amd/ps/ps-sdw-dma.c            | 373 ++++++++++++++----
 17 files changed, 1618 insertions(+), 354 deletions(-)
 create mode 100644 sound/soc/amd/acp/amd-acp70-acpi-match.c
 create mode 100644 sound/soc/amd/ps/ps-common.c

-- 
2.43.0




More information about the kernel-team mailing list