ACK: [SRU][N:linux-gcp/N:linux-gke/N:linux-gkeop][PATCH v2 0/7] IDPF: TX timeout and crash

[Massimiliano Pellizzer]

On Fri, 28 Mar 2025 at 00:42, Ian Whitfield <ian.whitfield at canonical.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2093622
>
> [Impact]
> Google has requested a patchset to be backported to resolve an issue in
> the IDPF module. The issue can lead to timeouts and potentially a system
> crash.
>
> [Fix]
> Backport a patchset from linux upstream to all IDPF-enabled Google
> kernels. This thread is for Noble, another thread was sent for Jammy
> and Oracular each, because they require separate patchsets. Plucky has
> already received these fixes through upstream updates. For more details
> on the backport process, each commit message includes a note about any
> manual patch edits that were needed.
>
> [Test Plan]
> Google provided an iperf3 stress test, which I performed on two bare
> metal machines using the IDPF driver. There were no errors reported by
> the kernel after running the stress test for 24+ hours.
>
> [Regression Potential]
> This is a large backport and affects several kernels. Because these
> kernels have diverged from upstream, most of the patches did not apply
> cleanly, which increases the chance of human error in the backport
> process. Problems related to this fix could lead to further issues in
> the Intel IDPF module, but there have been no changes to other drivers
> or the core kernel.
>
> v2: Resubmitted without patches that have already been applied since v1.
>     The patchset was previously reverted for all kernels over regression
>     concerns, and has been more thoroughly tested since. Google asked
>     that two additional patches were included in v2:
>     e4891e4687c8 ("idpf: split &idpf_queue into 4 strictly-typed queue structures")
>     f01032a2ca09 ("idpf: fix memory leaks and crashes while performing a soft reset")
>     which also led to the inclusion of an additional commit:
>     c00d33f1fc79 ("idpf: make virtchnl2.h self-contained")
>     to reduce merge conflicts.
>
> Alexander Lobakin (3):
>   idpf: make virtchnl2.h self-contained
>   idpf: split &idpf_queue into 4 strictly-typed queue structures
>   idpf: fix memory leaks and crashes while performing a soft reset
>
> Joshua Hay (3):
>   idpf: enable WB_ON_ITR
>   idpf: add support for SW triggered interrupts
>   idpf: trigger SW interrupt when exiting wb_on_itr mode
>
> Pavan Kumar Linga (1):
>   idpf: fix idpf_vc_core_init error path
>
>  drivers/net/ethernet/intel/idpf/idpf.h        |   3 +-
>  drivers/net/ethernet/intel/idpf/idpf_dev.c    |   5 +
>  .../net/ethernet/intel/idpf/idpf_ethtool.c    | 125 +--
>  drivers/net/ethernet/intel/idpf/idpf_lib.c    |  77 +-
>  .../ethernet/intel/idpf/idpf_singleq_txrx.c   | 150 +--
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 952 +++++++++++-------
>  drivers/net/ethernet/intel/idpf/idpf_txrx.h   | 472 ++++++---
>  drivers/net/ethernet/intel/idpf/idpf_vf_dev.c |   5 +
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   |  74 +-
>  drivers/net/ethernet/intel/idpf/virtchnl2.h   |   4 +-
>  10 files changed, 1108 insertions(+), 759 deletions(-)
>
> --
> 2.43.0
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Massimiliano Pellizzer <massimiliano.pellizzer at canonical.com>

-- 
Massimiliano Pellizzer