[SRU][J:linux-bluefield][PATCH v1 1/3] Revert "UBUNTU: SAUCE: gpio-mlxbf3: During reboot test, ipmb driver fails to load intermittently"

David Thompson davthompson at nvidia.com
Fri May 2 19:22:26 UTC 2025


BugLink: https://bugs.launchpad.net/bugs/2109756

This reverts commit ebf5d642edb2e6580ee62aeda1c70bc84123dee5.

Signed-off-by: David Thompson <davthompson at nvidia.com>
Reviewed-by: Asmaa Mnebhi <asmaa at nvidia.com>
---
 drivers/gpio/gpio-mlxbf3.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/gpio/gpio-mlxbf3.c b/drivers/gpio/gpio-mlxbf3.c
index 1646325f1283..9d1bd3f6e23f 100644
--- a/drivers/gpio/gpio-mlxbf3.c
+++ b/drivers/gpio/gpio-mlxbf3.c
@@ -39,8 +39,6 @@
 #define MLXBF_GPIO_CAUSE_OR_EVTEN0        0x14
 #define MLXBF_GPIO_CAUSE_OR_CLRCAUSE      0x18
 
-#define MLXBF_GPIO_CLR_ALL_INTS           0xFFFFFFFF
-
 struct mlxbf3_gpio_context {
 	struct gpio_chip gc;
 
@@ -87,8 +85,6 @@ static void mlxbf3_gpio_irq_disable(struct irq_data *irqd)
 	val = readl(gs->gpio_cause_io + MLXBF_GPIO_CAUSE_OR_EVTEN0);
 	val &= ~BIT(offset);
 	writel(val, gs->gpio_cause_io + MLXBF_GPIO_CAUSE_OR_EVTEN0);
-
-	writel(BIT(offset), gs->gpio_cause_io + MLXBF_GPIO_CAUSE_OR_CLRCAUSE);
 	raw_spin_unlock_irqrestore(&gs->gc.bgpio_lock, flags);
 
 	gpiochip_disable_irq(gc, offset);
@@ -271,15 +267,6 @@ static int mlxbf3_gpio_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static void mlxbf3_gpio_shutdown(struct platform_device *pdev)
-{
-	struct mlxbf3_gpio_context *gs = dev_get_drvdata(&pdev->dev);
-
-	/* Disable and clear all interrupts */
-	writel(0, gs->gpio_cause_io + MLXBF_GPIO_CAUSE_OR_EVTEN0);
-	writel(MLXBF_GPIO_CLR_ALL_INTS, gs->gpio_cause_io + MLXBF_GPIO_CAUSE_OR_CLRCAUSE);
-}
-
 static const struct acpi_device_id mlxbf3_gpio_acpi_match[] = {
 	{ "MLNXBF33", 0 },
 	{}
@@ -292,7 +279,6 @@ static struct platform_driver mlxbf3_gpio_driver = {
 		.acpi_match_table = mlxbf3_gpio_acpi_match,
 	},
 	.probe    = mlxbf3_gpio_probe,
-	.shutdown = mlxbf3_gpio_shutdown,
 };
 module_platform_driver(mlxbf3_gpio_driver);
 
-- 
2.43.2




More information about the kernel-team mailing list