[PATCH v1 1/1] pinctrl: mlxbf3: Fix return value check for devm_platform_ioremap_resource

Asmaa Mnebhi asmaa at nvidia.com
Mon May 5 18:08:17 UTC 2025


Apologies. I will resubmit this with the correct subject format in v2.

> -----Original Message-----
> From: Asmaa Mnebhi <asmaa at nvidia.com>
> Sent: Monday, May 5, 2025 10:36 AM
> To: kernel-team at lists.ubuntu.com
> Cc: Asmaa Mnebhi <asmaa at nvidia.com>; David Thompson
> <davthompson at nvidia.com>; Chen Ni <nichen at iscas.ac.cn>; Linus Walleij
> <linus.walleij at linaro.org>
> Subject: [PATCH v1 1/1] pinctrl: mlxbf3: Fix return value check for
> devm_platform_ioremap_resource
> 
> From: asmaa <asmaa at nvidia.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2109973
> 
> Fix return value check for devm_platform_ioremap_resource() in
> mlxbf3_pinctrl_probe().
> 
> Signed-off-by: Chen Ni <nichen at iscas.ac.cn>
> Acked-by: Asmaa Mnebhi <asmaa at nvidia.com>
> Link: https://lore.kernel.org/20240621091637.2299310-1-nichen@iscas.ac.cn
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org> (cherry picked from
> commit 0cd9f140389bcd876e23aa3c06eea07f42892ad4)
> Signed-off-by: asmaa <asmaa at nvidia.com>
> ---
>  drivers/pinctrl/pinctrl-mlxbf3.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c
> index 7d1713824a89..ffb5dda364dc 100644
> --- a/drivers/pinctrl/pinctrl-mlxbf3.c
> +++ b/drivers/pinctrl/pinctrl-mlxbf3.c
> @@ -259,16 +259,16 @@ static int mlxbf3_pinctrl_probe(struct
> platform_device *pdev)
>  		return PTR_ERR(priv->fw_ctrl_set0);
> 
>  	priv->fw_ctrl_clr0 = devm_platform_ioremap_resource(pdev, 1);
> -	if (IS_ERR(priv->fw_ctrl_set0))
> -		return PTR_ERR(priv->fw_ctrl_set0);
> +	if (IS_ERR(priv->fw_ctrl_clr0))
> +		return PTR_ERR(priv->fw_ctrl_clr0);
> 
>  	priv->fw_ctrl_set1 = devm_platform_ioremap_resource(pdev, 2);
> -	if (IS_ERR(priv->fw_ctrl_set0))
> -		return PTR_ERR(priv->fw_ctrl_set0);
> +	if (IS_ERR(priv->fw_ctrl_set1))
> +		return PTR_ERR(priv->fw_ctrl_set1);
> 
>  	priv->fw_ctrl_clr1 = devm_platform_ioremap_resource(pdev, 3);
> -	if (IS_ERR(priv->fw_ctrl_set0))
> -		return PTR_ERR(priv->fw_ctrl_set0);
> +	if (IS_ERR(priv->fw_ctrl_clr1))
> +		return PTR_ERR(priv->fw_ctrl_clr1);
> 
>  	ret = devm_pinctrl_register_and_init(dev,
>  					     &mlxbf3_pin_desc,
> --
> 2.47.0




More information about the kernel-team mailing list