[SRU][P][PATCH 3/7] wifi: ath12k: remove redundant vif settings during link interface creation
Kuan-Ying Lee
kuan-ying.lee at canonical.com
Thu Sep 11 07:24:22 UTC 2025
From: Aditya Kumar Singh <aditya.kumar.singh at oss.qualcomm.com>
BugLink: https://bugs.launchpad.net/bugs/2122397
Currently, vif level settings are done in ath12k_mac_assign_link_vif() as
well as in ath12k_mac_op_add_interface(). Since it is vif level settings,
doing this on per link does not make sense and it contributes to redundant
code. Get rid of this redundant code from ath12k_mac_assign_link_vif().
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1.97421.5 # Nicolas Escande
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan at oss.qualcomm.com>
Signed-off-by: Aditya Kumar Singh <aditya.kumar.singh at oss.qualcomm.com>
Tested-by: Nicolas Escande <nico.escande at gmail.com>
Link: https://patch.msgid.link/20250204-unlink_link_arvif_from_chanctx-v2-3-764fb5973c1a@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson at oss.qualcomm.com>
(cherry picked from commit ab6270c4dec3b1a506291c3b0050230b32464781)
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee at canonical.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 310238473de2..e987ceabda78 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -4026,13 +4026,6 @@ static struct ath12k_link_vif *ath12k_mac_assign_link_vif(struct ath12k_hw *ah,
sizeof(arvif->bitrate_mask.control[i].vht_mcs));
}
- /* Allocate Default Queue now and reassign during actual vdev create */
- vif->cab_queue = ATH12K_HW_DEFAULT_QUEUE;
- for (i = 0; i < ARRAY_SIZE(vif->hw_queue); i++)
- vif->hw_queue[i] = ATH12K_HW_DEFAULT_QUEUE;
-
- vif->driver_flags |= IEEE80211_VIF_SUPPORTS_UAPSD;
-
rcu_assign_pointer(ahvif->link[arvif->link_id], arvif);
ahvif->links_map |= BIT(link_id);
synchronize_rcu();
--
2.43.0
More information about the kernel-team
mailing list