[SRU][Noble][OEM-6.17][PATCH 1/1] media: ov08x40: Fix the horizontal flip control
You-Sheng Yang
vicamo.yang at canonical.com
Mon Jan 12 07:32:27 UTC 2026
From: Hao Yao <hao.yao at intel.com>
BugLink: https://bugs.launchpad.net/bugs/2116170
The datasheet of ov08x40 doesn't match the hardware behavior.
0x3821[2] == 1 is the original state and 0 the horizontal flip enabled.
Signed-off-by: Hao Yao <hao.yao at intel.com>
Reviewed-by: Hans de Goede <hansg at kernel.org>
Tested-by: Hans de Goede <hansg at kernel.org> # ThinkPad X1 Carbon Gen 12 & Gen 13
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus at linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco at kernel.org>
(cherry picked from commit c7df6f339af94689fdc433887f9fbb480bf8a4ed)
Signed-off-by: You-Sheng Yang <vicamo.yang at canonical.com>
---
drivers/media/i2c/ov08x40.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c
index abbb0b774d43f..536456b4c4819 100644
--- a/drivers/media/i2c/ov08x40.c
+++ b/drivers/media/i2c/ov08x40.c
@@ -2640,7 +2640,7 @@ static int ov08x40_set_ctrl_hflip(struct ov08x40 *ov08x, u32 ctrl_val)
return ov08x40_write_reg(ov08x, OV08X40_REG_MIRROR,
OV08X40_REG_VALUE_08BIT,
- ctrl_val ? val | BIT(2) : val & ~BIT(2));
+ ctrl_val ? val & ~BIT(2) : val | BIT(2));
}
static int ov08x40_set_ctrl_vflip(struct ov08x40 *ov08x, u32 ctrl_val)
--
2.51.0
More information about the kernel-team
mailing list