NACK: [SRU][J/N:linux-bluefield][PATCH v2 0/1] mmc: core: Avoid bitfield RMW for claim/retune flags

[Alessio Faina]

On Thu, Mar 12, 2026 at 10:01:50AM -0400, Penghe Geng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2143925
> 
> SRU Justification:
> 
> [Impact]
> 
> The host->claimed bit shared a word with retune flags. Writes to claimed
> in __mmc_claim_host() or retune_now in mmc_mq_queue_rq() can overwrite
> other bits when concurrent updates happen in other contexts, triggering
> spurious WARN_ON(!host->claimed).
> 
> [Fix]
> 
> Convert claimed, can_retune, retune_now and retune_paused to bool to remove shared-word coupling.
> 
> [Test Case]
> 
> * Boot BlueField-3 platform and verify that there are no instances of
>   "WARN_ON(!host->claimed)" call trace in dmesg log.
> 
> [Regression Potential]
> 
> None
> 
> [Notes]
> 
> This patch is already merged to the mainline.  The mainline commit is
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=901084c51a0a8fb42a3f37d2e9c62083c495f824
> 
> Penghe Geng (1):
>   mmc: core: Avoid bitfield RMW for claim/retune flags
> 
>  include/linux/mmc/host.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Hello Penghe,
 sorry to have to NACK this again, but, if you look at the threading
 with an application like MUTT, you will see that v2 has been added to
 the same thread as v1, and this makes complicated to ACK/APPLY the
 patchset, as they are intertwined.
 Could you please send a v3, with the same content as v2, but in a
 different, new thread?

 Kind regards,

     -Alessio Faina