NACK/Cmnt: [PATCH 1/1][SRU][J] UBUNTU: SAUCE: cifs: fix null pointer dereference in find_ipc_from_server_path

[Stefan Bader]

On 05/05/2026 10:43, ghadi.rahme at canonical.com wrote:
> From: Ghadi Elie Rahme <ghadi.rahme at canonical.com>
> 
> BugLink: https://launchpad.net/bugs/2150730
> 
> Signed-off-by: Ghadi Elie Rahme <ghadi.rahme at canonical.com>
> ---

Rejected for the following reasons:
This is not SRU material. The patch has no explanation but also SAUCE is 
only to be used in very rare cases where picking upstream changes is not 
possible. Which should be explained in a cover-email.

-Stefan
>   fs/cifs/dfs_cache.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index 61575cc81fbb..924ed7c90682 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -98,7 +98,7 @@ static struct cifs_ses *find_ipc_from_server_path(struct cifs_ses **ses, const c
>   
>   	get_ipc_unc(path, unc, sizeof(unc));
>   	for (; *ses; ses++) {
> -		if (!strcasecmp(unc, (*ses)->tcon_ipc->treeName))
> +		if ((*ses)->tcon_ipc && !strcasecmp(unc, (*ses)->tcon_ipc->treeName))
>   			return *ses;
>   	}
>   	return ERR_PTR(-ENOENT);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 52669 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20260505/43916587/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20260505/43916587/attachment-0001.sig>