[Bug 94022] Kopete jabber groupchat history only shown for currently present members

[dystopianray]

Public bug reported:

Binary package hint: kopete

When entering a jabber groupchat, the history provided by the server is
filtered by kopete so it only shows history from members who are
currently present in the groupchat.

This makes the history nearly useless as significant portions of it may
be missing depending on who is currently in the room.

It should show the entire history that is given, regardless of who may
or may not be in the room at the time of joining it. It had this
behaviour in previous versions but it seems to have been changed in one
of the 0.12.x releases.

The filtered history results in error messages being printed in
~/.xsession-errors

kopete (jabber): WARNING: [virtual void
JabberGroupContact::handleIncomingMessage(const XMPP::Message&)] the
contact is not in the list   : lounge at rooms.jabber.org.au/Clax

This behaviour is a regression in kopete 0.12.x that was not present in
previous versions.

The reason this behaviour occurs is becuase of an erroneous 'return'
statement present directly before the code that handles groupchat
members who are not currently present in the room.

I have reported this many months ago as kde bug #135211
(http://bugs.kde.org/show_bug.cgi?id=135211) and provided a patch to fix
this problem, however there has been no response from kopete developers.

I have tested the patch and I use jabber groupchats almost every day, I
have not encountered any adverse affects from using the patch and the
history is correctly shown.

** Affects: kdenetwork (upstream)
     Importance: Unknown
         Status: Unknown
** Affects: kdenetwork (Ubuntu)
     Importance: Undecided
         Status: Unconfirmed

-- 
Kopete jabber groupchat history only shown for currently present members
https://launchpad.net/bugs/94022