[Bug 414572] Re: KDE Microblogs plasmoid does not show friend timelines nor public timeline

[D. Wegener]

Additional information.  It seems to have something to do with the kubuntu_02_microblog_default_configuration.diff.  This diff appears in revision 29 of the lp:~kubuntu-members/kdeplasma-addons/ubuntu branch.  The following code in the downloadHistory method was changed:
+-    if (m_includeFriends) {
+-        query = QString("TimelineWithFriends:%1@%2");
+-    } else {
+         query = QString("Timeline:%1@%2");
+     }

The new code is:
++    if (m_password.isEmpty()) {
++        query = QString("NoAuth:%1@%2");
++    } else if ( m_includeFriends ) {
+         query = QString("Timeline:%1@%2");
+     }

The result is that an empty password results in a NoAuth query,  If
Include Friends is checked, the query is Timeline when it should be
TimelineWithFriends.  If Include Friends isn't checked, then no query is
set.

The code should probably be changed to:
++    if (m_password.isEmpty()) {
++        query = QString("NoAuth:%1@%2");
++    } else if ( m_includeFriends ) {
+         query = QString("TimelineWithFriends:%1@%2");
+-    } else {
+         query = QString("Timeline:%1@%2");
+     }


There also seems to be a bug in setting the Configure... button state.  It isn't being cleared.  The setAuthRequired method seems to be used to turn this button on and off.  My best guess is that the method should be called in the dataUpdated method when the update query was successful.

-- 
KDE Microblogs plasmoid does not show friend timelines nor public timeline
https://bugs.launchpad.net/bugs/414572
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kdeplasma-addons in ubuntu.