[Bug 423877] [NEW] Please drop patch kubuntu_10_turn_on_kwin_compositing.diff

Martin Gräßlin ubuntu at martin-graesslin.com
Thu Sep 3 18:17:32 UTC 2009


Public bug reported:

Binary package hint: kdebase-workspace

The patch dates back to a time when kwin did not have a selftest for compositing yet. Nowadays it's completely unneeded as:
1. kwin has a self check to test if compositing is working, if not compositing is automagically disabled
2. kwin has a whitelist for some hardware. If the hardware is listed the self check is executed. If the hardware is not listed, the compositing self check can be enforced by the user by enabling it in the desktop effects kcm.
3. The fact that a card (or a driver) works with Compiz does not say anything about it working in kwin. Unfortunatelly there is still external breakage (this shouldn't be an issue in stable releases though).
4. If there is an error in kwin's whitelist, the whitelist should be fixed instead of using a somewhat other whitelist. (Changing the whitelist is rather simple and we have done it for minor releases)
5. The patch doesn't work anyway: it will only be used for drivers which are not "intel", "nvidia", "radeon", "fglrx"
Personally I doubt there are anymore vendors which can provide a decent compositing experience. For SGI & Co. it's better to keep it turned off.

If you get rid of the patch you can as well remove the strange
dependency to compiz-wrapper and you are closer to the upstream package.

If you still think that kwin's whitelist is suboptimal it would be the
better choice to just enable kwin's compositing by default in kubuntu-
default-settings. That way the self-check will be used in each startup
and compositing will be activated for systems where it works. That is
probably more reliable than the current patch. Nevertheless I think the
Upstream default is really the best choice.

** Affects: kdebase-workspace (Ubuntu)
     Importance: Undecided
         Status: New

-- 
Please drop patch kubuntu_10_turn_on_kwin_compositing.diff
https://bugs.launchpad.net/bugs/423877
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kdebase-workspace in ubuntu.




More information about the kubuntu-bugs mailing list