[Bug 1022414] Re: konquets existsing game aborts without warning if new selected from game menu

[michael]

** Description changed:

  konquest exectutes the following on selecting game->new.
  MainWindow::startNewGame()
  {
      m_gameView->deleteLater();
      m_game->deleteLater();
      setupGameView();
      m_gameView->startNewGame();
  }
  
- By calling  setupGameView(); we are aborting the current game
- regardlless of whether or not the new game dialog is cancled. This
- should only only be done if GameView::shutdownGame() returns true. This
- is a possiable regression from 4.8.3.
+ By calling  setupGameView(); we are aborting the current game regardlless of whether or not the new game dialog is cancled. This should only only be done if GameView::shutdownGame() returns true. Further, since startNewGame is called on the new GameView it will never display confirmation before terminating the existing game.
+ Edit: Just realized I patched my 4.8.3 copy too.

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kdegames in Ubuntu.
https://bugs.launchpad.net/bugs/1022414

Title:
  konquets existsing game aborts without warning if new selected from
  game menu

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kdegames/+bug/1022414/+subscriptions