Roll out of new code to codebrowse.launchpad.net

Michael Hudson michael.hudson at canonical.com
Thu Jul 5 09:02:55 BST 2007


Martin Pitt wrote:
> Hi Michael,
> 
> thanks for the update.
> 
> Michael Hudson [2007-07-04 12:50 +0100]:
>> As I haven't mentioned my work on loggerhead/codebrowse on this list
>> before, it makes sense to ask if anyone has any particular feature
>> requests for this part of launchpad.  There was a thread on the Bazaar
>> list about this a couple of weeks ago:
> 
> The UI works very well in general for me.

Cool.

> The only (but huge) gripe
> that I have with it is that the URLs are so exceptionally ugly.

Oh yes, I am well aware of this one:
https://bugs.launchpad.net/loggerhead/+bug/98826

> Pointing someone to the main page is still ok:
> 
>   http://codebrowse.launchpad.net/~ubuntu-core-dev/restricted-manager/trunk/changes
> 
> But if you want to point to a particular revision, (very common in
> IRC, in a changelog, etc.), then you apparently have to use a beast
> like 
> 
>   http://codebrowse.launchpad.net/~ubuntu-core-dev/restricted-manager/trunk/revision/martin.pitt%40ubuntu.com-20070625111434-a7o8ax94hswiv6dg?start_revid=martin.pitt%40ubuntu.com-20070625132945-hw4e2di3579bqxe4
> 
> Why are these timestamps and hashes necessary? URLs like this don't
> look very stable,

Actually, they are more stable that a URL based on revision numbers,
because revision numbers aren't stable in the face of --push-overwrite.

> and they are too long for sensible changelog
> inclusion, etc. As with webcvs/websvn etc., it should be possible to
> just specify the revision number, like
> 
> http://codebrowse.launchpad.net/~ubuntu-core-dev/restricted-manager/trunk/revision/124

Did you try that?  It actually works, though there's no way at all to
find this out...

> Likewise, pointing to a particular file shouldn't look like
> 
>   http://codebrowse.launchpad.net/~ubuntu-core-dev/restricted-manager/trunk/annotate/martin%40piware.de-20070621134643-cxx9od902gxfmgab?file_id=setup.py-20070301105013-3v30f2qw21qia3mn-1
> 
> But more like
> 
> http://codebrowse.launchpad.net/~ubuntu-core-dev/restricted-manager/trunk/annotate?file=setup.py

Again,
http://codebrowse.launchpad.net/~ubuntu-core-dev/restricted-manager/trunk/annotate/head:/setup.py

> Is this possible in some way?

These alternate urls have been possible for a while now, but probably
what should change is that codebrowse should generate them.  This isn't
going to be totally trivial, loggerhead works internally with rev- and
file-ids for good reasons, but it should probably be done.

Cheers,
mwh




More information about the launchpad-users mailing list