Need reviews

[James Page]

Hi Bilal

On Tue, 7 Jun 2016 at 11:28 Bilal Baqar <bbaqar at plumgrid.com> wrote:

> Hey James
>
> Would appreciate some help from you on this.
>

Sorry - managed to miss your last email.


>
> Regards
>
> On Wed, May 25, 2016 at 10:33 PM, Bilal Baqar <bbaqar at plumgrid.com> wrote:
>
>> Thanks for the reviews. I would like to move the charms to github and the
>> openstack project asap. I will need your help though.
>>
>> I am guessing my first steps should be to move the charms to github.
>> Should I move them to the plumgrid github account? I.e.
>> https://github.com/plumgrid/charm-plumgrid-director.
>>
>
I think this is a good first step as it provides a great place to import
the charms under /openstack once we get to that poin.


> Once we get there I am assuming we will have a stable14.04 and next14.04
>> branches? Which one would be connected to the openstack project?
>>
>
master branch == development so no need to create any extra branches IMHO.

we're doing 3 months releases for other openstack charms based on the date
- so stable/16.04 is the most recent at the moment.

You'll need to add tox, testr and gitreview files to each repository prior
to the move to openstack - take a look at one of the other openstack charms
for examples for what is required.

Can I check on the licensing of your charm? I'm about to propose switching
all of the existing openstack charms to apache 2.0 as that's required for
us to gain full project status in the OpenStack big tent, so it would be
great if the PLUMgrid charms started off this way!

We have Ubuntu OpenStack CI hooked into gerrit and running amulet tests at
the moment; I would suggest that you aim to setup similar functionality for
PLUMgrid so that you can verify changes prior to landed.


> I am would really appreciate if you could help clear this confusion for
>> me.
>>
>> Regards
>> On May 25, 2016 9:41 PM, "James Page" <james.page at canonical.com> wrote:
>>
>>> OK - all LGTM - I made a few tweaks to ensure that the bin directory
>>> does not get checked into bzr, and to sort out execution of charm-proof
>>> under a venv.
>>>
>>> It would be nice to get you guys moved away from bzr and to git - and
>>> maybe even under the OpenStack project?  I can help Shepard you on your way
>>> to that goal.
>>>
>>>
>>> On Wed, 25 May 2016 at 17:25 James Page <james.page at canonical.com>
>>> wrote:
>>>
>>>> Doing these reviews right now...
>>>>
>>>> Somehow I just feel in the way these days - lets see what we can do
>>>> about that...
>>>>
>>>> On Wed, 18 May 2016 at 11:14 Bilal Baqar <bbaqar at plumgrid.com> wrote:
>>>>
>>>>> Hey James
>>>>>
>>>>> We are trying to get Mitaka and Liberty enabled in OIL. I have pushed
>>>>> the following merge proposals:
>>>>>
>>>>>    - neutron-api-plumgrid
>>>>>    <https://code.launchpad.net/~plumgrid-team/charms/trusty/neutron-api-plumgrid/trunk/+merge/295026>
>>>>>
>>>>>    <https://code.launchpad.net/~plumgrid-team/charms/trusty/neutron-api-plumgrid/trunk/+merge/295026>
>>>>>    - plumgrid-director
>>>>>    <https://code.launchpad.net/~plumgrid-team/charms/trusty/plumgrid-director/trunk/+merge/295027>
>>>>>    - plumgrid-edge
>>>>>    <https://code.launchpad.net/~plumgrid-team/charms/trusty/plumgrid-edge/trunk/+merge/295029>
>>>>>    - plumgrid-gateway
>>>>>    <https://code.launchpad.net/~plumgrid-team/charms/trusty/plumgrid-gateway/trunk/+merge/295030>
>>>>>
>>>>> Check them out whenever you have time.
>>>>>
>>>>> Regards
>>>>> --
>>>>> Bilal Baqar
>>>>> MTS - PLUMgrid Inc.
>>>>>
>>>>>
>>>>>
>
>
> --
> Bilal Baqar
> MTS - PLUMgrid Inc.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/openstack-charmers/attachments/20160607/b2d7b236/attachment-0001.html>