[Merge] lp:~utlemming/ubuntu/oneiric/glance/oneiric into lp:~openstack-ubuntu-packagers/glance/ubuntu

Clint Byrum clint at fewbar.com
Tue Aug 23 18:46:45 UTC 2011


Review: Needs Fixing
Hi Ben!

This will need to be changed a bit. 

* 'service x x' is not really allowed in maintainer scripts. You will need to use 'invoke-rc.d glance-api stop' instead (this is so that users can override a package's desire to start/stop a service.)

* If you bump the standards, its good to assert that you did so and didn't need to change anything. You can see what changes are necessary by installing 'debian-policy' and reading /usr/share/doc/debian-policy/upgrading-checklist.txt.gz

Otherwise it looks good.
-- 
https://code.launchpad.net/~utlemming/ubuntu/oneiric/glance/oneiric/+merge/72202
Your team OpenStack Ubuntu packagers is subscribed to branch lp:~openstack-ubuntu-packagers/glance/ubuntu.



More information about the Openstack-packaging mailing list