[Merge] lp:~rafaeldtinoco/britney/hints-ubuntu into lp:~ubuntu-release/britney/hints-ubuntu

Christian Ehrhardt  christian.ehrhardt at canonical.com
Thu Jul 18 05:12:50 UTC 2019


Review: Disapprove

Hi Rafael,
there are a few things we need to change.

First of all, once a Ubuntu version is releases it gets branched and stays with its own version of hints. In this case this is an MP of the main hints (for the current devel release) vs the merge target of the main release (for eoan).

So for the badtest (if we need it) it would need to base in and go to [2].

And as a final little detail, the reviewers on such an MP don't have to be Archive Admins. Instead for already released Disco versions I'd usually expect the SRU team.

But IMHO we'd want to change other things for Disco anyway.

Summarizing:
- I have fixed that issue in Eoan as part of the merge of chrony 3.5
- In Eoan the old badtest chrony/3.4-4ubuntu2 does not trigger, but doesn't have to
  (can be cleaned up at some point)
- the iproute change in Disco is triggering this issue in Disco now
- In disco, so far there is no badtest for chrony
  That is correct as it only gets bad due to the new other packages, it was fine so far until the 
  new iproute as seen in [1]
- It seems that not the iproute changes, but some other changes in disco between 21st of 
  May and today trigger this. I ran a disco autopkgtest without proposed which confirmed this.

Options:
- we can badtest 3.4-1ubuntu1 for now if iproute2 is urgent
and either after that or right now instead of the badtest
- we can upload a fix to Disco as well.

I think we need:
For clksim upstream changes
- https://salsa.debian.org/debian/chrony/commit/bb79b3247c1938b40f7532a4aa445da16148f822
For ?systemd? changes
- https://git.launchpad.net/ubuntu/+source/chrony/commit/?id=ebdec551cbb6a0986bfd489e4ca90ef103e37a07
Not sure if we really need still this then:
- https://git.tuxfamily.org/chrony/chrony.git/commit/?id=62d6aed6a64b887c9e3b7f03d9e0db1deaa2696a


I'd claim our team reiview slot and reject this MP for now to then work with you on bug 1836882 and bug 1836929 to bring that fix into Disco as well. That should fix the tests and then unblock anything that depends on them.

[1]: http://autopkgtest.ubuntu.com/packages/c/chrony/disco/amd64
[2]: bzr+ssh://bazaar.launchpad.net/~ubuntu-sru/britney/hints-ubuntu-disco/
-- 
https://code.launchpad.net/~rafaeldtinoco/britney/hints-ubuntu/+merge/370271
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~rafaeldtinoco/britney/hints-ubuntu into lp:~ubuntu-release/britney/hints-ubuntu.



More information about the ubuntu-archive mailing list