[Merge] lp:~khurshid-alam/unity-settings-daemon/media-keys-fix into lp:unity-settings-daemon

[Khurshid Alam]

Khurshid Alam has proposed merging lp:~khurshid-alam/unity-settings-daemon/media-keys-fix into lp:unity-settings-daemon.

Commit message:
* media-keys: Add more debug info

  This backports commits dc13b2d, 5f01643 & a09ae56 from gnome-settings-daemon.

* media-keys: Fix cancelled async calls usage

  This backports commits 86cbfda + 5147e6b & 214145c from gnome-settings-daemon.

* DESKTOP_SESSION is now unity

  Unity uses legacy key-grabber code. But since artful unity isn't the default session anymore and 
  DESKTOP_SESSION changed from ubuntu to unity. Fixes LP: #1755106 LP: #1188569 LP: #1727842

Requested reviews:
  Unity Settings Daemon Development Team (unity-settings-daemon-team)
Related bugs:
  Bug #1188569 in unity (Ubuntu): "Some keyboard shortcuts randomly stop working"
  https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1188569
  Bug #1727842 in unity (Ubuntu): "Volume and Mute buttons on keyboard not doing anything in Unity after upgrade to 17.10"
  https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1727842
  Bug #1755106 in unity-settings-daemon (Ubuntu): "/org/gnome/settings-daemon/plugins/media-keys/custom-keybindings/ fails to load"
  https://bugs.launchpad.net/ubuntu/+source/unity-settings-daemon/+bug/1755106

For more details, see:
https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/media-keys-fix/+merge/359935

It may seem unnecessary to add debug info for each dbus method call (revno: 4187), but I noticed session name change only after I added the debug info in the first place. Beside I don't want to partially backport commit for no reason. They do no harm. 

And since I have other fixes just for media-key plugin, this will keep size of each MR & no of MRs short. 
-- 
Your team Unity Settings Daemon Development Team is requested to review the proposed merge of lp:~khurshid-alam/unity-settings-daemon/media-keys-fix into lp:unity-settings-daemon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 9034 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-desktop/attachments/20181130/a2c1830a/attachment.diff>