acpitool: MOTU, the first blood

[Emil Oppeln-Bronikowski]

On Sunday 29 of May 2005 16:58, Reinhard Tartler wrote:

> I have taken a look at your source package. Your build dependencies
> are way to strict, please don't include any package with priority
> "required" such as gcc or libstdc++, as you can expect the buildd's to
> have them installed. 

 OK, noted.

> Also, plase try to get your package lintian 
> clean, that means without any Errors or Warings from lintian (there
> are both)

 I had none. Maybe I changed something and didn't check out after? It's going 
to be on my TODO list then.

> Your package build cleanly with gcc-4, so there is no reason to
> prohibit that in debian/control.

 I had no GCC-4 to test it. It's build again Hoary, because I can not swich to 
Breezy now.

> I didn't really try your package out, but looking at the source, it
> seems that toshiba laptops are better supported than other acpi
> implementations. 

 That was the reason why I got intrested in this program, I have a Toshiba 
laptop.

> A simple "AcpiTool is (yet another) 
> Linux ACPI client." is way too vague.

 I agree. Will be fixed.

> If you have any questions, please join us at #ubuntu-motu and ask. You
> may ping me again if you want me to rereview your package.

 I will not steal you more weekend. I need to polish this package first. :-)

-- 
 Emil Oppeln-Bronikowski, http://bronikowski.com