[Bug 353924] Re: Offline home page always English (browser language hard-coded to en-US)
Timo Jyrinki
timo.jyrinki at iki.fi
Fri Apr 3 05:57:35 UTC 2009
Tested that the fix is not working, mostly because the browser always
returns en-US.
22:19 < asac> so we need to fix the other bug which was made wontfix upstream
because we shouldnt use the other mechanism
---
(what changed since intrepid)
22:26 < asac> Mirv: we dropped localized pref for user locale
---
22:28 < asac> usually i dont like reopening old bugs
22:28 < asac> if its a regression its a different bug
22:28 < asac> this is different because its an upstream bug
---
** Description changed:
Binary package hint: ubufox
-
- Probably commit
- http://bazaar.launchpad.net/~asac/ubufox/main/revision/149 broke the
- showing of localized home page in offline mode. The code is still there
- but in jaunty it doesn't seem to work anymore. For example,
- file:///usr/share/ubuntu-artwork/home/locales/index-fi_FI.html would
- still be there to use in Ubuntu 9.04, and it is also updated for 9.04.
- However, it is now never shown to the users.
The problem seems to be that general.useragent.locale is always en-US,
and only general.useragent.locale is queried in the startpage.html code.
Probably some sort of thing returned by JavaScript should be used
instead, since I don't have anything in about:config that would tell my
Ubuntu's and browser's language correctly.
However, I don't know how would I be able to get the correct language
even in JavaScript, since navigator.language, window.navigator.language
seem to also be hard-coded to en-US, together with the part of
navigator.userAgent. _Only_ the Accept-Language HTTP header shows the
correct language.
Attaching a test HTML page. With Ubuntu 8.10, I get correct fi-FI locale
in all three boxes. In Ubuntu 9.04, I get en-US in all of those.
This bug probably should be limited to ubufox / start page problem even
though it now has lots of information. Therefore I re-opened bug #117915
- for the navigator language problem in general.
+ for the navigator language problem in general. It was now again closed,
+ but there is a relevant upstream bug linked to it.
(
Original description was...
Commit http://bazaar.launchpad.net/~asac/ubufox/main/revision/141.1.1
resetted all URLs for the offline home page to the English version,
resulting in that the (existing) localized versions aren't shown. The
URLs are browser.throbber.url and app.update.url.details in
ubufox.properties.
- ...and it was false in that the URLs in ubufox.properties are not needed anymore because of the code in startpage.html, which works in Ubuntu 8.10
+ ...and it was false in that the URLs in ubufox.properties are not
+ needed anymore because of the code in startpage.html, which works in
+ Ubuntu 8.10
+
+ Then the description was...
+
+ Probably commit
+ http://bazaar.launchpad.net/~asac/ubufox/main/revision/149 broke the
+ showing of localized home page in offline mode. The code is still there
+ but in jaunty it doesn't seem to work anymore. For example,
+ file:///usr/share/ubuntu-artwork/home/locales/index-fi_FI.html would
+ still be there to use in Ubuntu 9.04, and it is also updated for 9.04.
+ However, it is now never shown to the users.
+
+ ...but it is also false, or at least the code would work with the patch in this bug, but probably otherwise too. So we just don't get anything else than en-US from anywhere.
)
--
Offline home page always English (browser language hard-coded to en-US)
https://bugs.launchpad.net/bugs/353924
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to ubufox in ubuntu.
More information about the Ubuntu-mozillateam-bugs
mailing list