[Bug 303269]

Ehsan-mozilla 303269 at bugs.launchpad.net
Mon Aug 15 15:14:58 UTC 2011


Comment on attachment 553143
part2: do not override manually set dictionary

>+  PRBool mUpdateDictionaryRunning;
>+  PRBool mDictWasSetManually;

Please use PRPackedBool.

>+class UpdateDictionnaryHolder {
>+  private:
>+    nsEditorSpellCheck* mSpellCheck;
>+  public:
>+    UpdateDictionnaryHolder(nsEditorSpellCheck* esc): mSpellCheck(esc) {
>+      if (mSpellCheck) {
>+        mSpellCheck->BeginUpdateDictionary();
>+      }
>+    }
>+    ~UpdateDictionnaryHolder() {
>+      if (mSpellCheck) {
>+        mSpellCheck->EndUpdateDictionary();
>+      }
>+    }
> };

Also, please move this class to the cpp file.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/303269

Title:
  Automatically select language for spell check based on user input

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/303269/+subscriptions




More information about the Ubuntu-mozillateam-bugs mailing list