[Bug 1261351]

[Mpt-postinbox]

The solution currently proposed in bug 678345 seems targeted at a
different case, where an attachment filename conflicts with pre-existing
files in the destination folder. "Skip" would be what you want in the
case of "I know you've been working on these files, but I forgot to send
you all of them". And "Replace" would be what you want in the case of "I
didn't send you all the files last time, here's an updated set".

But that would not fix this bug. Whether the default button was "Skip"
or "Replace", the default behavior for same-named attachments would
*still* be for only one of the attachments to be saved! "Skip" would
save only the first one, and "Replace" would save only the last one. And
if "Rename" was the default button, that would again nearly defeat the
purpose of "Save All", not to mention being on the wrong side of the
dialog.

It's possible for the two cases to happen simultaneously -- for some
attachments to have the same filename, while either those or others have
the same filenames as pre-existing files in the destination folder. For
example, someone on an iOS device might mail you several "image.jpeg"
photos in one message, then several more "image.jpeg" photos in a second
message, which you save in the same folder.

Therefore, the cases can't (or at least shouldn't) be handled with
separate dialogs. Nonetheless, I think the solutions are different. The
solution for pre-existing files is the dialog, because their filenames
may be important to preserve. But the solution for same-named
attachments is just to choose a unique name automatically, no questions
asked. Having the same name means that the filenames were not important
(or that the paths need changing post-save anyway), so there is no point
in asking before choosing a unique name.

-- 
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla.
https://bugs.launchpad.net/bugs/1261351

Title:
  "Save All" for same-named attachments defaults to only one saved file

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/1261351/+subscriptions