[Bug 1187570] Re: Uploading photos on Google+ not working
Bug Watch Updater
1187570 at bugs.launchpad.net
Thu Jun 6 09:52:27 UTC 2013
Launchpad has imported 40 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=875252.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.
------------------------------------------------------------------------
On 2013-05-23T10:03:13+00:00 Benjamin Kerensa wrote:
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130522153407
Steps to reproduce:
Try to click on Upload from computer on Google+
Actual results:
The button/element is unclickable
Expected results:
It should be clickable and launch a file browser so I can select and
upload photos to Google+
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/0
------------------------------------------------------------------------
On 2013-05-23T10:04:52+00:00 Benjamin Kerensa wrote:
Here is a video showing the issue.... I re-installed Firefox on Ubuntu
and checked in two other browsers and can confirm this is specific to
Firefox 22 on Ubuntu but also did not occur in earlier versions of
Firefox.
http://www.youtube.com/watch?v=1IyiOGXjxW4
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/1
------------------------------------------------------------------------
On 2013-05-23T10:33:45+00:00 Epinal99-bugzilla wrote:
Could you run mozregression to find a possible regression range and provide the changeset, please.
http://harthur.github.io/mozregression/
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/2
------------------------------------------------------------------------
On 2013-05-23T10:57:44+00:00 Benjamin Kerensa wrote:
I was unable to find a regression and more specifically I think this is
related to the recent major overhaul Google+ did. I think they changed
something in their design thats just not meshing well with FF.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/3
------------------------------------------------------------------------
On 2013-05-23T18:23:09+00:00 Sphink wrote:
Created attachment 753384
Allows spaces within filter expressions
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/4
------------------------------------------------------------------------
On 2013-05-23T18:26:55+00:00 Sphink wrote:
Sorry! Wrong bug.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/5
------------------------------------------------------------------------
On 2013-05-27T04:37:42+00:00 Ananuti wrote:
Good: 20130327031035
http://hg.mozilla.org/mozilla-central/rev/178a4a770bb1
http://download.cdn.mozilla.net/pub/mozilla.org/firefox/nightly/2013/03/2013-03-27-03-10-35-mozilla-central/
Bad: 20130328031013
http://hg.mozilla.org/mozilla-central/rev/962f5293f87f
http://download.cdn.mozilla.net/pub/mozilla.org/firefox/nightly/2013/03/2013-03-28-03-10-13-mozilla-central/
Pushlog: https://hg.mozilla.org/mozilla-
central/pushloghtml?fromchange=178a4a770bb1&tochange=962f5293f87f
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/6
------------------------------------------------------------------------
On 2013-05-27T09:02:27+00:00 Alice0775 wrote:
Try Aurora23.0a2. this is duplicate of Bug 52500 if Aurora works fine.
(I could not verify the problem because I am no Google+ account)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/7
------------------------------------------------------------------------
On 2013-05-27T09:11:48+00:00 Ananuti wrote:
(In reply to Alice0775 White from comment #7)
> Try Aurora23.0a2. this is duplicate of Bug 52500 if Aurora works fine.
> (I could not verify the problem because I am no Google+ account)
Nooo. I can reproduce /w Nightly as well.
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20130526 Firefox/24.0
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/8
------------------------------------------------------------------------
On 2013-05-28T05:55:35+00:00 Supphachoke Suntiwichaya wrote:
Confirm I can't upload from G+ and Facebook. Firefox 22beta Linux and OS
X
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/9
------------------------------------------------------------------------
On 2013-05-28T06:13:46+00:00 Ananuti wrote:
Alice, can you please activate G+ account and narrow down the regression
range?
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/10
------------------------------------------------------------------------
On 2013-05-28T06:59:01+00:00 Alice0775 wrote:
last Good: f372d9cf7d5c
First Bad: 9e55e669d3ac
Triggered by:
9e55e669d3ac Mounir Lamouri — Bug 838695 - Move nsFileControlFrame click handling to nsHTMLInputElement. r=smaug
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/11
------------------------------------------------------------------------
On 2013-05-28T11:15:53+00:00 Mounir wrote:
Is that still reproducible in current Nightly? I landed something that,
I believe, should have fixed that kind of problems.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/12
------------------------------------------------------------------------
On 2013-05-28T11:22:01+00:00 Alice0775 wrote:
(In reply to Mounir Lamouri (:mounir) from comment #12)
> Is that still reproducible in current Nightly? I landed something that, I
> believe, should have fixed that kind of problems.
I can reproduce the problem in latest Nightly
http://hg.mozilla.org/mozilla-central/rev/a39263b0c896
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130527 Firefox/24.0 ID:20130527031027
and
http://hg.mozilla.org/mozilla-central/rev/a39263b0c896
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20130527 Firefox/24.0 ID:20130527031027
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/13
------------------------------------------------------------------------
On 2013-05-28T11:22:20+00:00 Ananuti wrote:
(In reply to Mounir Lamouri (:mounir) from comment #12)
> Is that still reproducible in current Nightly? I landed something that, I
> believe, should have fixed that kind of problems.
Still reproducible on mozilla-inbound changeset ce60c6798292
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20130528 Firefox/24.0
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/14
------------------------------------------------------------------------
On 2013-05-28T11:30:34+00:00 Mounir wrote:
Sorry, as Alice in comment 7, I assumed the problem was coming from bug
52500. I will need a reduced test case to look into this.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/15
------------------------------------------------------------------------
On 2013-05-28T13:20:18+00:00 Alice0775 wrote:
I cannot provide reduced test case.
(I think that Google person is best to prepare testcase :)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/16
------------------------------------------------------------------------
On 2013-05-29T19:31:42+00:00 Akeybl wrote:
(In reply to Mounir Lamouri (:mounir) from comment #15)
> Sorry, as Alice in comment 7, I assumed the problem was coming from bug
> 52500. I will need a reduced test case to look into this.
Please don't wait on a reporter to help with a test - it's really
important that we reproduce locally and start investigating as soon as
possible, given the size of this web property.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/17
------------------------------------------------------------------------
On 2013-05-29T20:41:16+00:00 Alice0775 wrote:
Created attachment 755584
testcase (not sure whether exactly same as behavior of G+)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/18
------------------------------------------------------------------------
On 2013-05-29T20:57:10+00:00 Alice0775 wrote:
Created attachment 755592
testcase (not sure whether exactly same as behavior of G+)
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/19
------------------------------------------------------------------------
On 2013-05-30T00:28:46+00:00 Benjamin Kerensa wrote:
(In reply to Alex Keybl [:akeybl] from comment #17)
> (In reply to Mounir Lamouri (:mounir) from comment #15)
> > Sorry, as Alice in comment 7, I assumed the problem was coming from bug
> > 52500. I will need a reduced test case to look into this.
>
> Please don't wait on a reporter to help with a test - it's really important
> that we reproduce locally and start investigating as soon as possible, given
> the size of this web property.
Hi Alex,
Let me know how to produce a testcase. I am currently now seeing
Facebook image upload also does not work although that could be a
seperate bug. But yeah the severity of this is pretty high considering
the amount of people who visit these two properties.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/20
------------------------------------------------------------------------
On 2013-05-30T08:34:42+00:00 R-bugs-h wrote:
Benjamin, could you check if the Facebook problem has the same
regression range?
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/21
------------------------------------------------------------------------
On 2013-05-30T13:34:38+00:00 Mounir wrote:
Created attachment 755913
Reduced testcase
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/22
------------------------------------------------------------------------
On 2013-05-30T13:48:45+00:00 Mounir wrote:
The problem is that the created HTMLInputElement doesn't have any
presContext so we stop early in ::PreHandleEvent() and
::PostHandleEVent(). The reasons why we have those limitations and how
easy it would be to remove them are not really known to me. Olli
probably knows more.
I assume that fixing this for Beta is probably not a good idea. I think
there would be two alternatives for Beta (and Aurora?): backing out the
patches or override ::Click() to show a file picker if the element
doesn't have a prescontext at that time. Olli, would that be a safe
workaround?
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/23
------------------------------------------------------------------------
On 2013-05-30T13:57:51+00:00 Mounir wrote:
Related bugs are:
- bug 234455 which started preventing events when there is no prescontext;
- bug 329509 which seems to be about stopping that.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/24
------------------------------------------------------------------------
On 2013-05-30T15:27:10+00:00 R-bugs-h wrote:
So how did this work before the changes? bug 329509 is definitely not
something for beta.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/25
------------------------------------------------------------------------
On 2013-05-30T15:29:44+00:00 R-bugs-h wrote:
Could we just put back the old nsHTMLInputElement::Click() ?
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/26
------------------------------------------------------------------------
On 2013-05-31T17:13:26+00:00 Mounir wrote:
(In reply to Olli Pettay [:smaug] from comment #26)
> Could we just put back the old nsHTMLInputElement::Click() ?
As said in comment 23, I believe this could work. I would be fine with
backing out the required patch for Beta and think a bit more for
Aurora/Nightly.
Note: I am unassigning myslef given that I will be mostly offline until
the 12th, feel free te reassign me if it is fine having this being
looked at in 10 days.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/27
------------------------------------------------------------------------
On 2013-05-31T17:52:02+00:00 R-bugs-h wrote:
I think we have to fix this asap.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/28
------------------------------------------------------------------------
On 2013-05-31T23:25:22+00:00 Benjamin Kerensa wrote:
(In reply to Olli Pettay [:smaug] from comment #21)
> Benjamin, could you check if the Facebook problem has the same regression
> range?
I think the FB issue was just a glitch because its working for me now
and I have not had any version change on FF.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/29
------------------------------------------------------------------------
On 2013-05-31T23:27:21+00:00 Benjamin Kerensa wrote:
(In reply to Olli Pettay [:smaug] from comment #28)
> I think we have to fix this asap.
I totally agree I had hoped there would be a patch out for this by today
since its been a few weeks now that I have actually had to use Chromium
for photo uploads on G+ and I imagine some users could be contemplating
switching completely.
Notably a few linux distros like Ubuntu are shipping Firefox 22.0 as
stable so this is affecting a very large amount of users probably in the
millions.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/30
------------------------------------------------------------------------
On 2013-06-02T23:33:25+00:00 R-bugs-h wrote:
Created attachment 757187
patch
Mounir is on vacation, so jst could you review?
Patches for Bug 838695 and
http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsGenericHTMLElement.cpp?rev=ff4d7b275942&mark=2807-2807,2813-2820#2806
may help reviewing.
I'll write mochitest tomorrow.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/31
------------------------------------------------------------------------
On 2013-06-02T23:34:20+00:00 R-bugs-h wrote:
https://tbpl.mozilla.org/?tree=Try&rev=f50b20c34359
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/32
------------------------------------------------------------------------
On 2013-06-03T19:54:17+00:00 R-bugs-h wrote:
Created attachment 757570
with tests
https://tbpl.mozilla.org/?tree=Try&rev=be3374e9cab4
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/33
------------------------------------------------------------------------
On 2013-06-03T22:02:58+00:00 R-bugs-h wrote:
Created attachment 757658
for aurora+beta
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 838695
User impact if declined: G+, for example, is a bit broken
Testing completed (on m-c, etc.): about to land
Risk to taking this patch (and alternatives if risky): Should be reasonable safe.
Effectively bringing back the old behavior
String or IDL/UUID changes made by this patch: NA
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/34
------------------------------------------------------------------------
On 2013-06-03T22:09:11+00:00 R-bugs-h wrote:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d09f920a86f6
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/35
------------------------------------------------------------------------
On 2013-06-04T05:03:24+00:00 Supphachoke Suntiwichaya wrote:
lastest from me.
FF 22beta
Debian Linux
Linux mrchoke-debian 2.6.32-5-amd64 #1 SMP Fri May 10 08:43:19 UTC 2013 x86_64 GNU/Linux
Google+ not work.
Facebook work fine.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/36
------------------------------------------------------------------------
On 2013-06-04T09:25:13+00:00 R-bugs-h wrote:
This landed to mozilla-inbound yesterday, and should land to mozilla-central today, so
the next nightly, or nightly after that should have the fix.
Then the patch needs approval before it can land to aurora and beta.
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/37
------------------------------------------------------------------------
On 2013-06-04T14:20:06+00:00 Emorley wrote:
https://hg.mozilla.org/mozilla-central/rev/d09f920a86f6
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/38
------------------------------------------------------------------------
On 2013-06-04T20:02:02+00:00 Ryanvm wrote:
https://hg.mozilla.org/releases/mozilla-aurora/rev/afa4b9a24f20
https://hg.mozilla.org/releases/mozilla-beta/rev/7a0168d559d8
Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1187570/comments/39
** Changed in: firefox
Status: Unknown => Fix Released
** Changed in: firefox
Importance: Unknown => High
--
You received this bug notification because you are a member of Mozilla
Bugs, which is subscribed to Mozilla Firefox.
https://bugs.launchpad.net/bugs/1187570
Title:
Uploading photos on Google+ not working
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1187570/+subscriptions
More information about the Ubuntu-mozillateam-bugs
mailing list