[Bug 1452698] Re: [SRU] Issue in sahara-common.postinst.in: sahara-db-manage is executet on fresh install (even without a db-connection)

[Denis Egorenko]

https://code.launchpad.net/~degorenko/ubuntu/+source/sahara/+git/sahara/+merge/269246

https://code.launchpad.net/~degorenko/sahara/bug-1452698/+merge/269235

** Changed in: sahara (Ubuntu)
       Status: Confirmed => In Progress

** Changed in: sahara (Ubuntu)
     Assignee: (unassigned) => Denis Egorenko (degorenko)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to sahara in Ubuntu.
https://bugs.launchpad.net/bugs/1452698

Title:
  [SRU] Issue in sahara-common.postinst.in: sahara-db-manage is executet
  on fresh install (even without a db-connection)

Status in sahara package in Ubuntu:
  In Progress

Bug description:
  Hi there,

  i dont know if this is the right place for this bug-report!?

  But the following script-lines will execute sahara-db-manage, even on
  an fresh install without any configured db-connection.

      if ! grep -qE "^(sql_)?connection( )?=.*" ${SAHARA_CONF} || \
           grep -qE "^(sql_)?connection.*sqlite.*" ${SAHARA_CONF}; then
                  su -s /bin/sh -c 'sahara-db-manage --config-file /etc/sahara/sahara.conf upgrade head' sahara
      fi

  Becuse the default is:

  #connection=<None>

  and this matches the negated grep .

  # lsb_release -rd
  Description:	Ubuntu 14.04.2 LTS
  Release:	14.04

  # apt-cache policy sahara-common
  sahara-common:
    Installed: 2015.1.0-0ubuntu1~cloud0
    Candidate: 2015.1.0-0ubuntu1~cloud0
    Version table:
   *** 2015.1.0-0ubuntu1~cloud0 0
          500 http://ubuntu-cloud.archive.canonical.com/ubuntu/ trusty-proposed/kilo/main amd64 Packages
          100 /var/lib/dpkg/status
       2015.1~rc1-0ubuntu1~cloud0 0
          500 http://ubuntu-cloud.archive.canonical.com/ubuntu/ trusty-updates/kilo/main amd64 Packages

  Regards
  Tino


  [Impact]
  sahara install fails with:

  Traceback (most recent call last):
    File "/usr/bin/sahara-db-manage", line 10, in <module>
      sys.exit(main())
    ...
    File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/strategies.py", line 51, in create
      entrypoint = u._get_entrypoint()
  AttributeError: 'NoneType' object has no attribute '_get_entrypoint'

  
  [Test Case]
  apt-get install sahara

  
  [Regression Potential]
  Minimal regression impact.  The difference after this change is that the user (or installation tool) will need to run 'sahara-db-manage' after sahara is installed and configured to create the database schema.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sahara/+bug/1452698/+subscriptions