[Bug 1374663] Re: agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Corey Bryant]

Shane,

Thanks for the patch. Just a few minor comments:
* did you mean to bump concurrency to 16? it's probably fine since it's just for running tests. just want to make sure it doesn't lock up the next dev's machine. :)
* if it's possible to cherry-pick this patch from the next higher available upstream release branch/tag (> icehouse) then I'd prefer you did that (git checkout icehouse-eol; git cherry-pick -x uuid of commit).
* also relevant patch headers should be added: http://packaging.ubuntu.com/html/patches-to-packages.html#patch-headers

Thanks,
Corey

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to neutron in Ubuntu.
https://bugs.launchpad.net/bugs/1374663

Title:
  agent/linux/ip_lib.py does not correctly handle output from 'iproute2'
  command

Status in Ubuntu Cloud Archive:
  New
Status in neutron:
  Fix Released
Status in neutron package in Ubuntu:
  In Progress

Bug description:
  [Impact]

   * The get_devices() method in neutron/agent/linux/ip_lib.py chokes if 'iproute2' presents interface names containing '@', such as ipip tunnels and macvlan devices:
    
  		tunl0 at NONE: <NOARP> mtu 1480 qdisc noop state DOWN mode DEFAULT group default
  		clone at eth0: <BROADCAST,MULTICAST> mtu 1454 qdisc noop state DOWN mode DEFAULT
          
    * The mere presence of one of the above interface names will cause the
      code to fail with:

  		RuntimeError:
  		Command: ['ip', 'addr', 'show', 'tunl0 at NONE']
  		Exit code: 1
  		Stdout: ''
  		Stderr: 'Device "tunl0 at NONE" does not exist.\n'

  
  [Test Case]

   * This has been seen in the vpn_agent.log after upgrading to a xenial kernel (4.4.0-45-generic) in a trusty/icehouse environment.
     
      /var/log/neutron/vpn_agent.log:
      ERROR neutron.agent.linux.interface [-] Failed unplugging interface   'qg-e75da35-63 at if10' 

  
  [Regression Potential]

    * iproute2 is still used, however, a search path was added
  (/sys/class/net) which returns the interfaces without the '@'.

    * This has been fixed since Kilo so there is minimal regression
  potential.

  
  [ Other Info ]

    *

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions