[Bug 1710019] Re: support GICv3 ITS save/restore & migration

[dann frazier]

artful verification:
ubuntu at seyfert:~/vm-save-restore$ ./test.sh 
+ i=0
+ [ -f /var/log/libvirt/qemu/4172-0.log ]
+ name=4172-0
+ ./randmac.py
+ mac=00:16:3e:7b:3b:f1
+ uuidgen
+ uuid=33815e19-0f44-4e6f-8209-ada375484ba3
+ mktemp
+ xml=/tmp/tmp.Mc2sJDaknd
+ cp template.xml /tmp/tmp.Mc2sJDaknd
+ trap cleanup EXIT
+ mkdir -p vms
+ dd if=/dev/zero of=./vms/4172-0_CODE.fd bs=1M count=64
64+0 records in
64+0 records out
67108864 bytes (67 MB, 64 MiB) copied, 0.173587 s, 387 MB/s
+ dd if=/usr/share/qemu-efi/QEMU_EFI.fd of=./vms/4172-0_CODE.fd conv=notrunc
4096+0 records in
4096+0 records out
2097152 bytes (2.1 MB, 2.0 MiB) copied, 0.0523696 s, 40.0 MB/s
+ dd if=/dev/zero of=./vms/4172-0_VARS.fd bs=1M count=64
64+0 records in
64+0 records out
67108864 bytes (67 MB, 64 MiB) copied, 0.173042 s, 388 MB/s
+ cat
+ cloud-localds vms/4172-0_seed.img vms/4172-0_user-data
+ pwd
+ qemu-img create -f qcow2 -o backing_file=/home/ubuntu/vm-save-restore/zesty-server-cloudimg-arm64.img ./vms/4172-0.img
Formatting './vms/4172-0.img', fmt=qcow2 size=2361393152 backing_file=/home/ubuntu/vm-save-restore/zesty-server-cloudimg-arm64.img cluster_size=65536 lazy_refcounts=off refcount_bits=16
+ sed -i s/\#VM\#/4172-0/ /tmp/tmp.Mc2sJDaknd
+ pwd
+ sed -i s,\#DIR\#,/home/ubuntu/vm-save-restore, /tmp/tmp.Mc2sJDaknd
+ sed -i s/\#UUID\#/33815e19-0f44-4e6f-8209-ada375484ba3/ /tmp/tmp.Mc2sJDaknd
+ sed -i s/\#MAC\#/00:16:3e:7b:3b:f1/ /tmp/tmp.Mc2sJDaknd
+ sudo virsh define /tmp/tmp.Mc2sJDaknd
Domain 4172-0 defined from /tmp/tmp.Mc2sJDaknd

+ sudo virsh start 4172-0
Domain 4172-0 started

+ sleep 60
+ sudo virsh save 4172-0 ./vms/4172-0.sav

Domain 4172-0 saved to ./vms/4172-0.sav

+ sudo virsh restore ./vms/4172-0.sav
Domain restored from ./vms/4172-0.sav

+ sleep 5
+ sudo virsh save 4172-0 ./vms/4172-0.sav

Domain 4172-0 saved to ./vms/4172-0.sav

+ sudo virsh restore ./vms/4172-0.sav
Domain restored from ./vms/4172-0.sav

+ sudo virsh save 4172-0 ./vms/4172-0.sav

Domain 4172-0 saved to ./vms/4172-0.sav

+ sudo virsh restore ./vms/4172-0.sav
Domain restored from ./vms/4172-0.sav

+ cleanup
+ sudo virsh destroy 4172-0
Domain 4172-0 destroyed

+ sudo virsh undefine 4172-0 --nvram
Domain 4172-0 has been undefined

+ rm -f ./vms/4172-0.img ./vms/4172-0_CODE.fd ./vms/4172-0_VARS.fd
/tmp/tmp.Mc2sJDaknd ./vms/4172-0.sav vms/4172-0_user-data
vms/4172-0_seed.img


** Tags removed: verification-needed-artful
** Tags added: verification-done-artful

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1710019

Title:
  support GICv3 ITS save/restore & migration

Status in Ubuntu Cloud Archive:
  Invalid
Status in Ubuntu Cloud Archive ocata series:
  Fix Committed
Status in Ubuntu Cloud Archive pike series:
  Fix Released
Status in linux package in Ubuntu:
  In Progress
Status in qemu package in Ubuntu:
  Fix Released
Status in linux source package in Xenial:
  Won't Fix
Status in qemu source package in Xenial:
  Won't Fix
Status in linux source package in Zesty:
  In Progress
Status in qemu source package in Zesty:
  Triaged
Status in linux source package in Artful:
  Fix Committed
Status in qemu source package in Artful:
  Fix Released

Bug description:
  [Impact]
  Virtual machines on GICv3-based ARM systems cannot be saved/restored or migrated.
  This feature was added in QEMU 2.10.

  [Test Case]
  ubuntu at grotrian:~$ sudo virsh save 7936-0 7936-0.sav

  Domain 7936-0 saved to 7936-0.sav

  ubuntu at grotrian:~$ sudo virsh restore 7396-0.sav
  error: Failed to restore domain from 7396-0.sav
  error: operation failed: job: unexpectedly failed

  ubuntu at grotrian:~$ sudo tail -3 /var/log/libvirt/qemu/7936-0.log
  2017-08-10T21:26:38.217427Z qemu-system-aarch64: State blocked by non-migratable device 'arm_gicv3_its'
  2017-08-10T21:26:38.217565Z qemu-system-aarch64: load of migration failed: Invalid argument
  2017-08-10 21:26:38.217+0000: shutting down, reason=failed

  [Regression Risk]
  The kernel changes are restricted to ARM, minimizing the regression risk on other architectures. Other than one minor offset adjustment, all patches are clean cherry-picks from upstream. Tested on Cavium ThunderX and Qualcomm Centriq.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1710019/+subscriptions