[Bug 1899964] Re: Failover of loadbalancer fails when Amphora master is missing

[Nicolas Bock]

Verified with the following steps:

1. Create Train deployment with Octavia

./generate-bundle.sh --defaults --use-stable-charms --release train
--octavia --num-compute 2

2. Configure Octavia

juju config octavia loadbalancer-topology=ACTIVE_STANDBY
juju config octavia spare-pool-size=2

2. Create Cirros VMs

./tools/instance_launch.sh 2 cirros

3. Create fake webserver on VMs (See
https://code.launchpad.net/~nicolasbock/stsstack-bundles/+git/stsstack-
bundles/+merge/392344)

./tools/run_fake_webserver.sh

4. Create load balancer

./tools/create_octavia_lb.sh

5. Test load balancer with

curl LB_FIP

6. Shut down a nova-compute that is hosting one of the amphorae. This
   will break the load balancer due to https://storyboard.openstack.org/#!/story/2003084

7. Install SRU in octavia unit

8. Check load balancer with

openstack loadbalancer list

9. Verify operation with step 5.

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1899964

Title:
  Failover of loadbalancer fails when Amphora master is missing

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive train series:
  New
Status in Ubuntu Cloud Archive ussuri series:
  New
Status in Ubuntu Cloud Archive victoria series:
  Fix Released
Status in octavia package in Ubuntu:
  Fix Released
Status in octavia source package in Focal:
  New
Status in octavia source package in Groovy:
  Fix Released

Bug description:
  [Impact]
  (from storyboard desciption) Currently if taskflow process is interrupted (during create/update/failover - node is rebooted or service is restarted) - loadbalancer will stuck in PENDING state.
  Taskflow provides persistence module which allows to save flows state for recovery https://docs.openstack.org/taskflow/latest/user/persistence.html
  Otherwise partially created/updated/deleted resources should be moved to ERROR state when service is up again. (like it is done in Cinder)

  [Test Case]

  [Regression Potential]

  ------------------------------------------------------------------------

  Tried to failover a loadbalancer that has missing entries of amphora master.
  The loadbalancer went to ERROR state.

  OpenStack version: Train

  The fix is available in upstream as part of the Octavia Failover refactor patches in Train
  https://review.opendev.org/#/q/status:merged+project:openstack/octavia+branch:stable/train+topic:failover-refactor

  Verified with the upstream patches and it worked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1899964/+subscriptions