[Bug 1914584] Re: radosgw-admin user create error message confusing if user with email already exists

[Ponnuvel Palaniyappan]

Attaching the debdiff done for Luminous (based off Matthew Vernon's
patch).


** Description changed:

- Hi,
+ [Impact]
  
- The error message if you try and create an S3 user with an email address
- that is already associated with another S3 account is very confusing.
+ When creating a new S3 user, the error message is confusing if the email
+ address used is already associated with another S3 account.
  
  To reproduce:
  
  radosgw-admin user create --uid=foo --display-name="Foo test" --email=bar at domain.invalid
  #[ success ]
  radosgw-admin user create --uid=test --display-name="AN test" --email=bar at domain.invalid
  could not create user: unable to parse parameters, user id mismatch, operation id: foo does not match: test
  
- I've reported this upstream as https://tracker.ceph.com/issues/49137 and
- will send a patch against master there in due course, but that won't get
- backported to Luminous.
+ As a result, it's completely unclear what went wrong with the user
+ creation.
  
- I attach a patch that improves the error message thus:
- radosgw-admin user create --uid=test --display-name="AN test" --email=bar at domain.invalid
- could not create user: unable to create user test because user id foo already exists with email bar at domain.invalid
+ [Test case]
  
- Could this be applied to the luminous Ceph packages you ship please?
+ Create an S3 account via radosgw-admin. Then create another user but use
+ the same email address - it should provide a clear description of what
+ the problem is.
  
- Thanks,
+ [Where problems could occur]
  
- Matthew
+ The new message may yet be unclear or could complain that an email
+ exists even though it doesn't exist (false positive). It's an improved
+ diagnostic by checking if the email id exists. Perhaps, user creation
+ might become problematic if the fix doesn't work.
  
- ProblemType: Bug
- DistroRelease: Ubuntu 18.04
- Package: ceph-common 12.2.13-0ubuntu0.18.04.6
- ProcVersionSignature: Ubuntu 4.15.0-106.107-generic 4.15.18
- Uname: Linux 4.15.0-106-generic x86_64
- ApportVersion: 2.20.9-0ubuntu7.23
- Architecture: amd64
- Date: Thu Feb  4 11:13:55 2021
- ProcEnviron:
-  LANG=en_US.UTF-8
-  TERM=xterm
-  SHELL=/bin/bash
-  XDG_RUNTIME_DIR=<set>
-  PATH=(custom, no user)
- SourcePackage: ceph
- UpgradeStatus: Upgraded to bionic on 2018-11-20 (807 days ago)
- modified.conffile..etc.logrotate.d.ceph-common: [modified]
- mtime.conffile..etc.default.ceph: 2018-03-13T17:08:17.501935
- mtime.conffile..etc.logrotate.d.ceph-common: 2019-06-17T16:40:55.496716
+ [Other Info]
+ - The patch was provided by Matthew Vernon (attached here)
+ - Upstream tracker: https://tracker.ceph.com/issues/49137
+ - Upstream PR: https://github.com/ceph/ceph/pull/39293
+ - Backported to Pacific, Octopus, and Nautilus upstream releases. Luminous is EOL'ed upstream, so we'd like to backport to Luminous (Bionic/queens).

** Summary changed:

- radosgw-admin user create error message confusing if user with email already exists
+ [SRU] radosgw-admin user create error message confusing if user with email already exists

** Tags added: sts-sru-needed

** Attachment added: "debdiff.txt"
   https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1914584/+attachment/5471578/+files/debdiff.txt

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1914584

Title:
  [SRU] radosgw-admin user create error message confusing if user with
  email already exists

Status in Ceph:
  Unknown
Status in Ubuntu Cloud Archive:
  Triaged
Status in Ubuntu Cloud Archive queens series:
  Triaged
Status in Ubuntu Cloud Archive rocky series:
  Triaged
Status in Ubuntu Cloud Archive stein series:
  Triaged
Status in Ubuntu Cloud Archive train series:
  Triaged
Status in Ubuntu Cloud Archive ussuri series:
  Triaged
Status in Ubuntu Cloud Archive victoria series:
  Triaged
Status in ceph package in Ubuntu:
  Triaged
Status in ceph source package in Bionic:
  Triaged
Status in ceph source package in Focal:
  Triaged
Status in ceph source package in Groovy:
  Triaged
Status in ceph source package in Hirsute:
  Triaged

Bug description:
  [Impact]

  When creating a new S3 user, the error message is confusing if the
  email address used is already associated with another S3 account.

  To reproduce:

  radosgw-admin user create --uid=foo --display-name="Foo test" --email=bar at domain.invalid
  #[ success ]
  radosgw-admin user create --uid=test --display-name="AN test" --email=bar at domain.invalid
  could not create user: unable to parse parameters, user id mismatch, operation id: foo does not match: test

  As a result, it's completely unclear what went wrong with the user
  creation.

  [Test case]

  Create an S3 account via radosgw-admin. Then create another user but use
  the same email address - it should provide a clear description of what
  the problem is.

  [Where problems could occur]

  The new message may yet be unclear or could complain that an email
  exists even though it doesn't exist (false positive). It's an improved
  diagnostic by checking if the email id exists. Perhaps, user creation
  might become problematic if the fix doesn't work.

  [Other Info]
  - The patch was provided by Matthew Vernon (attached here)
  - Upstream tracker: https://tracker.ceph.com/issues/49137
  - Upstream PR: https://github.com/ceph/ceph/pull/39293
  - Backported to Pacific, Octopus, and Nautilus upstream releases. Luminous is EOL'ed upstream, so we'd like to backport to Luminous (Bionic/queens).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceph/+bug/1914584/+subscriptions