[Bug 1908375] Re: ceph-volume lvm list <device> calls blkid numerous times for differrent devices

[Dariusz Gadomski]

I have also made an attempt to run tasks.ceph_deploy test suite with
vstart as this seems to be the only one that makes use of `ceph-volume`,
but I have failed due to Python2/Python3 syntax issues.

I have set up venv with Python2 (since qa/tasks/vstart_runner.py is not
Python3 compatible) with teuthology (pip install
git+https://github.com/ceph/teuthology@luminous#egg=teuthology[test]).

Test run result:
Traceback (most recent call last):
  File "../qa/tasks/vstart_runner.py", line 1086, in <module>
    exec_test()
  File "../qa/tasks/vstart_runner.py", line 893, in exec_test
    args=["ps", "-u"+str(os.getuid())]
  File "../qa/tasks/vstart_runner.py", line 296, in run
    proc.wait()
  File "../qa/tasks/vstart_runner.py", line 164, in wait
    self.stdout.write(out)
TypeError: unicode argument expected, got 'str'

I'm not sure how to successfully run the suite, but I'll keep trying.

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph in Ubuntu.
https://bugs.launchpad.net/bugs/1908375

Title:
  ceph-volume lvm list <device> calls blkid numerous times for
  differrent devices

Status in ceph package in Ubuntu:
  Fix Released
Status in ceph source package in Bionic:
  In Progress
Status in ceph source package in Focal:
  Fix Released
Status in ceph source package in Groovy:
  Fix Released

Bug description:
  [Impact]

   * Every ceph-volume list lvm <device> call invokes blkid for numerous PARTUUIDs. For some setups with many slower IO devices this can make this call to run for minutes without any actual justification for that.
  In fact, the upstream ceph approach changed in this matter and post-bionic releases already have ceph-volume that does not invoke blkid at all in this context making the call much faster.

  Please examine the attached ceph-volume.log fragment for a ceph-volume
  call, the accumulated blkid calls take around 1 min 7 s.

  
  [Test Case]

   * Setup a ceph-osd with numerous block devices with long access time for blkid.
   * Run
  time ceph-volume --log-path ceph-volume.log --log-level debug lvm list <device>
  on one of them and check the log to see that most of the execution time is consumed by blkid calls.

  [Where problems could occur]

   * Although a potential fix does not introduce any changes to how
  ceph-volume is used any automation depending on ceph-volume log
  parsing may notice a change.

  [Other Info]
   
   * The fix to this is available for Focal and beyond.
   * Xenial is not affected due to lack of ceph-volume in its ceph release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1908375/+subscriptions