[Bug 1948934] Re: [Victoria] Backported test requires newer ddt than included in test-requirements.txt

[OpenStack Infra]

Reviewed:  https://review.opendev.org/c/openstack/cinder/+/815673
Committed: https://opendev.org/openstack/cinder/commit/bda74498d67a2d9d978eb1f522841387bec6310d
Submitter: "Zuul (22348)"
Branch:    stable/victoria

commit bda74498d67a2d9d978eb1f522841387bec6310d
Author: Eric Harney <eharney at redhat.com>
Date:   Wed Oct 27 10:15:17 2021 -0400

    Tests: Fix compatibility with ddt 1.2.x
    
    stable/victoria lists that ddt 1.2.1 is supported,
    but this decoration does not work with that version
    of ddt.
    
    Remove the TestNameFormat parameter for these tests.
    
    (stable-branch only fix)
    Closes-Bug: #1948934
    Change-Id: Ic91a978303f11617bf29c88bf82235998947552a


** Changed in: cloud-archive/victoria
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/1948934

Title:
  [Victoria] Backported test requires newer ddt than included in test-
  requirements.txt

Status in Cinder:
  In Progress
Status in Ubuntu Cloud Archive:
  New
Status in Ubuntu Cloud Archive victoria series:
  Fix Committed

Bug description:
  test-requirements.txt requires ddt>=1.2.1 ; however, 17.2.0 includes a
  test backport
  (cinder/tests/unit/volume/flows/test_create_volume_flow.py) that uses
  a module name that doesn't exist in DDT until 1.4.0
  (https://github.com/datadriventests/ddt/commit/6bf51b5d7887049eda580932643a5408ca0f5e3f)

  Running the unit tests results in the following traceback:

  =========================                                                                                                                   
  Failures during discovery                                                                                                                   
  =========================                                                                                                                   
  --- import errors ---                                                                                                                       
  Failed to import test module: cinder.tests.unit.volume.flows.test_create_volume_flow                                                        
  Traceback (most recent call last):                                                                                                          
    File "/usr/lib/python3.8/unittest/loader.py", line 436, in _find_test_path                                                                
      module = self._get_module_from_name(name)                                                                                               
    File "/usr/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name                                                          
      __import__(name)                                                                                                                        
    File "/build/cinder-17.2.0/cinder/tests/unit/volume/flows/test_create_volume_flow.py", line 1258, in <module>                             
      @ddt.ddt(testNameFormat=ddt.TestNameFormat.INDEX_ONLY)                                                                                  
  AttributeError: module 'ddt' has no attribute 'TestNameFormat'

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1948934/+subscriptions