[Bug 2035180] Re: [SRU] Backport Fix barbican client with application credentials/trusts to Ussuri/Victoria

[Mauricio Faria de Oliveira]

Hey David,

Thanks for the patches and SRU template, it looks good and to the point.

1) I'd just suggest to add more detail to 'Where problems could occur section'
(e.g., why is that a possible regression, and if there are other cases where
it wouldn't apply, say http only, or if a workaround is available if needed).

Regarding the debdiffs and .patch files -- mostly good too! Just a few
points:

2) The version increment in Ubuntu stable releases is almost always '0.1' 
(vs. '1' in Ubuntu development releases), see guide in [1]. 
For the Cloud Archive, the number in the ~cloudX suffix is incremented
(with '1' instead of '0.1' now :) instead of another ubuntuX(.Y) scheme at the end).

3) Some of the changelogs have an extra empty line before the signature.
Ah, and you may set TZ= for dch to pick up your timezone if you want.)
Bug number and patch file name format look good!

4) The git commit/patch format provides most fields (see Standard Fields in DEP3 [2];
e.g., Description/Subject, Origin/Author/From, Bug-Ubuntu), and only 'Origin:' and
'Bug-Ubuntu:' are usually required for Ubuntu SRUs, in addition.

Origin: ideally points to the commit merged upstream (instead of a review/issue/pr),
and has the 'backport' keyword (vs. 'upstream') only if changes were needed for the
patch to apply in the Ubuntu package (instead of whether the upstream commit itself
is a backport of an upstream change introduced in later versions).

Thanks again,
Mauricio

[1] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
[2] https://dep-team.pages.debian.net/deps/dep3/

** Changed in: octavia (Ubuntu Focal)
       Status: New => Incomplete

** Changed in: octavia (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: octavia (Ubuntu Focal)
     Assignee: (unassigned) => David Negreira (dnegreira)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/2035180

Title:
  [SRU] Backport Fix barbican client with application credentials/trusts
  to Ussuri/Victoria

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive ussuri series:
  Triaged
Status in Ubuntu Cloud Archive victoria series:
  Triaged
Status in Ubuntu Cloud Archive wallaby series:
  Triaged
Status in octavia package in Ubuntu:
  Fix Released
Status in octavia source package in Focal:
  Incomplete

Bug description:
  [Impact]

  * Users cannot add an HTTPS endpoint with octavia/barbican when using
  application credentials (it returns http error 500).

  [Test Case]

  * Full details of commands in comment #10, summary below.
  * Add a user in a project
  * Add the admin role to the user in the project
  * Create application credentials
  * Create a barbican certificate store
  * Create octavia loadbalancer and listener with the application credentials

  [Where problems could occur]

   * Users might not be able to create load balancers or attach a
  listener to a load balancer.

  [Other Info]

   * Original story: https://storyboard.openstack.org/#!/story/2007619
   * Upstream fix and backports: https://review.opendev.org/q/Id77ce36f59b71d309f153e5c1d44059f162ee440
   * Current upstream fix for octavia/Ussuri: https://review.opendev.org/c/openstack/octavia/+/894548
   * Current upstream fix for octavia/Victoria:https://review.opendev.org/c/openstack/octavia/+/894547

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2035180/+subscriptions