[Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form

[Timo Aaltonen]

Hello Nicolas, or anyone else affected,

Accepted horizon into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/horizon/3:18.3.5-0ubuntu2.2 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: horizon (Ubuntu Focal)
       Status: Triaged => Fix Committed

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to horizon in Ubuntu.
https://bugs.launchpad.net/bugs/1943639

Title:
  project/instances/attach_interface has O(N) scaling time complexity
  for opening form

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive ussuri series:
  Triaged
Status in Ubuntu Cloud Archive victoria series:
  Fix Committed
Status in Ubuntu Cloud Archive wallaby series:
  Fix Committed
Status in Ubuntu Cloud Archive xena series:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Fix Released
Status in horizon source package in Focal:
  Fix Committed

Bug description:
  [ Impact ]

  The time complexity of opening the project/instances/attach_interface
  form box is O(N) where N is the number of networks in the project with
  a large prefactor.

  This is due to

  https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210

  Which loops over the networks and requests the ports associated with
  the network. For large projects this scaling behavior can become
  prohibitive.

  The patch [1] addresses this issue by reducing the number of API calls
  and hence the prefactor of the algorithm.

  [ Test Plan ]

  In order to reproduce the issue, create a Nova VM and then add many
  networks. On the instances tab in the Horizon UI click on "attach
  interface" for the VM. It will take a moment for the dialog to appear.
  The exact time until the dialog appears will depend on the number of
  networks linearly.

  With [1] the time it takes for the dialog box to appear will be
  significantly shorter.

  [ Where problems could occur ]

  The patch [1] affects the "attach interface" dialog box and could
  break this UI feature in case something was wrong with the
  implementation. It is also possible that due to a bug in the
  implementation some networks are missing from the dialog.

  [1] https://review.opendev.org/c/openstack/horizon/+/866895

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions