[Bug 2095581] Re: [MIR] libsass-python

Ioanna Alifieraki 2095581 at bugs.launchpad.net
Tue Feb 18 16:29:46 UTC 2025 

Review for Source Package: libsass-pyhton

[Summary]

Security concerns are addressed in libsass itself 
(https://bugs.launchpad.net/ubuntu/+source/libsass/+bug/2095582)
libsass-python is merely a wrapper.
Also deprecation concerns are addressed/expained in aforementioned bug.


MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
This does not need a security review

List of specific binary packages to be promoted to main: python3-libsass, pysassc
Specific binary packages built, but NOT to be promoted to main: <None>

Notes:
Required TODOs:
1. Depends on https://bugs.launchpad.net/ubuntu/+source/libsass/+bug/2095582
2. Add autopkgtest tests.

- The package already has a team bug subscriber


[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
Ubuntu-openstack team is committed to own long term maintenance of this package.
The rationale given in the report seems valid and useful for Ubuntu

[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems:
-  other dependencies to MIR due to this

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
  signing, ...)

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- no new python2 dependency
- Python package, but using dh_python

Problems:
- does not have a non-trivial test suite that runs as autopkgtest

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good/
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems: None

[Upstream red flags]

OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?

Problems: None


** Changed in: libsass-python (Ubuntu)
       Status: New => Incomplete

** Changed in: libsass-python (Ubuntu)
     Assignee: Ioanna Alifieraki (joalif) => James Page (james-page)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2095581

Title:
  [MIR] libsass-python

Status in libsass-python package in Ubuntu:
  Incomplete

Bug description:
  Switch in horizon from pyscss and associate django plugin to libsass-
  python and the native library it wraps.

  https://review.opendev.org/c/openstack/requirements/+/934220

  https://opendev.org/openstack/horizon/commit/283219ab5ef4344e3808cd61b4cc0821886acffb
  https://opendev.org/openstack/horizon/commit/283219ab5ef4344e3808cd61b4cc0821886acffb

  
  libsass-python MIR

  [Availability]
  The package libsaas-python is already in Ubuntu universe.
  The package libsaas-python builds for the architectures it is designed to work on.
  It currently builds and works for architectures: amd64, arm64, armhf, ppc64el, riscv64, s390x
  Link to package https://launchpad.net/ubuntu/+source/libsass-python

  [Rationale]
  The package libsass-python is required in Ubuntu main because Horizon has switched from pyscss to libsass-python and the native library it wraps.
  The package libsass-python will generally be useful for a large part of our user base.
  The package libsass-python is a new runtime dependency of package OpenStack Horizon that we already support.

  There is no other/better way to solve this that is already in main or
  should go universe->main instead of this.

  The binary package libsass-python needs to be in main as it is a new
  dependency for OpenStack Horizon which is switching away from the
  previously used django_pyscss.

  The package libsass-python is required in Ubuntu main no later than
  February 20, 2025 due to feature freeze.

  [Security]
  No CVEs/security issues in this software in the past

  no executables in `/sbin` and `/usr/sbin`
  Package does not install services, timers or recurring jobs
  Packages does not open privileged ports (ports < 1024).
  Package does not expose any external endpoints
  Packages does not contain extensions to security-sensitive software.

  [Quality assurance - function/usage]
  TODO-A: - The package works well right after install

  [Quality assurance - maintenance]
  TODO: - The package is maintained well in Debian/Ubuntu/Upstream and does not have too many, long-term & critical, open bugs.
  The package does not deal with exotic hardware we cannot support.

  [Quality assurance - testing]
  The package runs a test suite on build time, if it fails it makes the build fail, link to build log (https://launchpadlibrarian.net/758454081/buildlog_ubuntu-plucky-amd64.libsass-python_0.23.0-0.1build1_BUILDING.txt.gz)

  The package does not run an autopkgtest. It has unit tests run at
  build time.

  [Quality assurance - packaging]
  debian/watch is present and works
  debian/control defines a correct Maintainer field (Frédéric Bonnard)

  This package does not yield massive lintian Warnings, Errors
  Please link to a recent build log of the package: https://launchpadlibrarian.net/758454081/buildlog_ubuntu-plucky-amd64.libsass-python_0.23.0-0.1build1_BUILDING.txt.gz
  Please attach the full output you have got from `lintian --pedantic` as an extra post to this bug - No output generated
  Lintian overrides are not present

  This package does not rely on obsolete or about to be demoted packages.
  This package has no python2 or GTK2 dependencies
  The package will not be installed by default

  Packaging and build is easy, link to debian/rules:
  https://git.launchpad.net/ubuntu/+source/libsass-
  python/tree/debian/rules

  [UI standards]
  Application is not end-user facing (does not need translation)

  [Dependencies]
  There are further dependencies that are not yet in main, MIR for them is at: https://bugs.launchpad.net/ubuntu/+source/libsass/+bug/2095582 (WIP). Libsass-python is a wrapper for the native package of libsass.

  [Standards compliance]
  This package correctly follows FHS and Debian Policy

  [Maintenance/Owner]
  The owning team will be Ubuntu Openstack Developers and I have their acknowledgement for that commitment.
  The future owning team is not yet subscribed, but will subscribe to the package before promotion.

  This does not use static builds
  This does not use vendored code
  This package is not rust based

  The package has been built within the last 3 months in the archive (Nov 11, 2024)
  Build link on launchpad: https://launchpad.net/ubuntu/+source/libsass-python/0.23.0-0.1build1

  [Background information]
  The Package description explains the package well
  Upstream Name is libsass-python
  Link to upstream project: https://github.com/sass/libsass-python

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libsass-python/+bug/2095581/+subscriptions

More information about the Ubuntu-openstack-bugs mailing list