[Bug 2116193] Re: openstack-pkg-tools fails to build packages containing a git tag version

[Nick Rosbrook]

Whoops, I forgot something important in my first review: this is a
native package (check debian/source/format). In this case, your patch
should edit the source directly, not via debian/patches.

Second, I missed that you forgot to mention the bug number in the
changelog. E.g., I would expect to see:

+openstack-pkg-tools (135ubuntu1) questing; urgency=medium
+
+  * d/p/lp2116193-pbr-version.patch: don't override existing pbr
+    version. (LP: #2116193)
+
+ -- Guillaume Boutry <guillaume.boutry at canonical.com>  Tue, 08 Jul 2025 17:39:35 +0200
+

Normally if I missed that in review, I would just add it myself. But
since we need another debdiff to re-work the patch anyways, please fix
this as well.

Sorry for missing these on the first pass!

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to openstack-pkg-tools in Ubuntu.
https://bugs.launchpad.net/bugs/2116193

Title:
  openstack-pkg-tools fails to build packages containing a git tag
  version

Status in openstack-pkg-tools package in Ubuntu:
  New

Bug description:
  When the debian version of the package where we use `openstack-pkg-
  tools` as a build helper  contains a git tag, that package will fail
  to build.

  This is due to https://salsa.debian.org/openstack-
  team/debian/openstack-pkg-
  tools/-/commit/94691c0a04d9ee06c24bc8fd9beee4ee8a61beaf which declares
  a new PBR_VERSION, overriding the one set in Ubuntu packages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openstack-pkg-tools/+bug/2116193/+subscriptions