[Bug 1713617] Re: [MIR] python-pyperclip, xclip

[Myles Penner]

Re-review for Source Package: xclip

[Summary]
MIR team ACK with the recommendation to address the following recommended TODOs. As this is a re-review, these recommendations are non-blocking but should be addressed by the owning team.
This does not need a security review
This is a re-review and all binaries and source packages currently exist in Main.

Notes:
Recommended TODOs:
This package has not been built since May 2024. Recommended to rebuild against newer versions of Ubuntu. 
This package does not have autopkgtests and the unit tests do not appear to fail the build upon failure. As this is a fairly simple utility, autopkgtests may not be strictly necessary but the unit tests should gate the build.

[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
A team is committed to own long term maintenance of this package - Ubuntu OpenStack
The rationale given in the report seems valid and useful for Ubuntu - This is a recommended dependency of python-pyperclip and the previous preferred dependency was removed upstream. This package is recommended as the next best alternative.

[Dependencies]
OK:
- no other runtime Dependencies to MIR due to this
- no other build-time Dependencies with active code in the final binaries
  to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems: None

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries

OK:
- not a go package, no extra constraints to consider in that regard
- No vendoring used, all Built-Using are in main
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source - treats clipboard data as raw bytes and does not attempt to interpret or parse.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
  signing, ...)
- this makes appropriate (for its exposure) use of established risk
  mitigation features (dropping permissions, using temporary environments,
  restricted users/groups, seccomp, systemd isolation features,
  apparmor, ...) - simple user command that inherits the user’s permissions

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite does not necessarily fail will fail the build upon error (missing ‘set -e’ in the xctest file)
- does not have an autopkgtest
- This does not need special HW for build or test

Problems:
- A potential problem for this package is that the xctest file does not necessarily fail the build when one of its tests fail. It is missing a ‘set -e’ line and does not propagate non-zero codes from failed diff comparisons.

[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under
  control
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is sporadic - last commit was January 2025
- Debian/Ubuntu update history is good - the latest update was from March 2024 though that is the current release upsteam
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

Problems: None

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?

Problems: None


** Changed in: xclip (Ubuntu)
     Assignee: Myles Penner (mylesjp) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is a bug assignee.
https://bugs.launchpad.net/bugs/1713617

Title:
  [MIR] python-pyperclip, xclip

Status in python-pyperclip package in Ubuntu:
  Fix Released
Status in xclip package in Ubuntu:
  Fix Committed

Bug description:
  [MIR] python-pyperclip

  [Availability]
  Currently in universe.

  [Rationale]
  python-pyperclip is needed as a new dependency of cmd2, which is part of the openstack dependency chain (via python-cliff).

  [Security]
  No security history.

  [Quality Assurance]
  Package works out of the box with no prompting. There are no major bugs in Ubuntu and there are no major bugs in Debian. Unit tests are run during build.

  [Dependencies]
  All are in main except xclip (see below).

  [Standards Compliance]
  FHS and Debian Policy compliant.

  [Maintenance]
  Simple python package that the OpenStack Team will take care of.

  [Background]
  A cross-platform clipboard module for Python.

  [MIR] xclip

  [Availability]
  Currently in universe.

  [Rationale]
  pyperclip depends on xclip.

  [Security]
  No security history.

  [Quality Assurance]
  Package works out of the box with no prompting. There are no major bugs in Ubuntu and there are no major bugs in Debian. Unit tests are run during build.

  [Dependencies]
  All are in main.

  [Standards Compliance]
  FHS and Debian Policy compliant.

  [Maintenance]
  Package that the OpenStack Team will take care of.

  [Background]
  xclip is a command line utility that is designed to run on any system with an
  X11 implementation. It provides an interface to X selections ("the clipboard")
  from the command line. It can read data from standard in or a file and place it
  in an X selection for pasting into other X applications. xclip can also print
  an X selection to standard out, which can then be redirected to a file or
  another program.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-pyperclip/+bug/1713617/+subscriptions