[Bug 2049507] Re: [SRU] retry on connection error to neutron

[Edward Hope-Morley]

The jammy-proposed package contains sru for both this bug and bug
2074504. I have verified the latter and in doing so can confirm
verification for this SRU also. As an extra step I am running tempest
tests against a deployment using jammy-proposed to be sure there are no
regressions and will report back with that data but for am effectively
declaring verification done:

# apt-cache policy manila-common
manila-common:
  Installed: 1:14.1.1-0ubuntu1.2
  Candidate: 1:14.1.1-0ubuntu1.2
  Version table:
 *** 1:14.1.1-0ubuntu1.2 500
        500 http://archive.ubuntu.com/ubuntu jammy-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     1:14.1.1-0ubuntu1.1 500
        500 http://availability-zone-3.clouds.archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages
     1:14.0.0-0ubuntu1 500
        500 http://availability-zone-3.clouds.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages


** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to manila in Ubuntu.
https://bugs.launchpad.net/bugs/2049507

Title:
  [SRU] retry on connection error to neutron

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive caracal series:
  Fix Released
Status in Ubuntu Cloud Archive yoga series:
  Fix Committed
Status in OpenStack Shared File Systems Service (Manila):
  Fix Released
Status in manila package in Ubuntu:
  Fix Released
Status in manila source package in Jammy:
  Fix Committed
Status in manila source package in Noble:
  Fix Released

Bug description:
  Retry https://paste.opendev.org/show/bCtEYsFr0oTfhY9b2r34/

  so that a connection error to neutron (maybe due to kubernetes
  maintenance) does not immediately lead to share create failure. May be
  retry for 5 times with keystone connection failure to avoid duplicate
  port create in neutron. If duplicate ports are created, they become
  orphan after share deletion. So Manila should give a try to make sure
  duplicate ports are not created.

  ===============
  SRU DESCRIPTION
  ===============

  [Impact]

  Temporary connectivity issues will cause immediate failures in share creation.
  This is an improvement very desired to be included in SRU of LP#2074504. We have not personally encountered this issue because it is very rare but it is a potential problem that was adressed prior to fixing LP#2074504 and further enhances LP#2074504's fix.

  [Test case]

  Given the nature of this bug, we cannot replicate this in the lab.
  Unit tests plus upstream CI validation that this works and doesn't
  break anything should suffice.

  [Where problems could occur]

  The code only affects the neutron plugin for manila, which is used
  only for DHSS=True mode. In case something breaks, it will fail to
  create new resources such as share servers and share networks.
  Existing resources should be fine and new shares should still be
  created fine in existing share servers and share networks. In case of
  a regression, the previous funcionality can be restored through
  package downgrade.

  [Other Info]

  This is only for Jammy/Yoga as part of SRU LP#2074504.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2049507/+subscriptions