[Bug 2139385] Re: Update Ceph to new 20.2.0 (Tentacle) version

[Renan Rodrigo]

Thanks for the pointers, Luciano!
I did an initial review, and those are the points I'd like to sort out:

- [Suggestion] The changelog entry for the new release is missing the LP reference to this bug.
- [Suggestion] The changelog mentions several removals, both for patches and d/ changes. It would be good to add a brief justification for each of those removals, to make it easier for future reviewers to understand the rationale behind them. Something like:
  * d/p/lp2080208.patch: Removed, no longer needed.
    [ Fixed upstream in version X.Y]
    
- [Important] lintian is reporting warnings/errors for a few reasons, including copyright information. Please run lintian against the source package and check those. It would be nice to have d/copyright sane, even more as we are ahead of Debian. If you check the lintian output and consider it fine, please add a comment here.
- [Important] There are changes to d/control and d/rules not mentioned in the changelog. I can see 
d/rules
+ export CMAKE_POLICY_VERSION_MINIMUM = 3.5

d/control

- libboost-process-dev
- libboost-system-dev (>= 1.82.0)
+ libboost-process1.90-dev

- [Question] Is it intentional that the libboost-system-dev dependency was removed?
- [Question] Is there a reason not to depend in the meta libboost-process-dev? In resolute it will point to 1.90 anyway. Matthias has added a patch to the current ceph version in ubuntu/devel to depend on the metapackage, I wonder if we could do the same here. If the answer is that you need to specify the version, wouldn't it be better to depend on libboost-process-dev (>= 1.90.0) instead of the specific package?

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to ceph in Ubuntu.
https://bugs.launchpad.net/bugs/2139385

Title:
   Update Ceph to new 20.2.0 (Tentacle) version

Status in ceph package in Ubuntu:
  In Progress

Bug description:
  [Impact]

  The update contains the following package updates:
  https://ceph.io/en/news/blog/2025/v20-2-0-tentacle-released/

  Key differences from upstream:
  - UADK is not used in ARM64 as it requires checking out a repository during
    build time.

  [Test Case]

  This SRU will run all functional tests with the packages in 'proposed'
  for every Ceph charm maintained by Canonical's Ceph team, so that
  there's a higher chance of catching bugs associated with any Ceph
  component.

  The charms for which the functional tests will be run are: ceph-mon, ceph-osd,
  ceph-radosgw, ceph-proxy, ceph-nfs, ceph-nvme, ceph-fs and ceph-rbd-mirror.

  [Regression Potential]

  Ceph is a critical package as it underpins large scale data storage
  and integrity checking, and care must be taken to not introduce any
  data loss regressions. ceph also is a common backing store for
  OpenStack virtual machines through ceph-rbd, and care must be taken to
  not break any API or ABI compatibility with current OpenStack
  releases.

  In order to mitigate the regression potential, the results of the
  aforementioned tests will be attached to this bug.

  [Other info]

  Link to merge request: https://code.launchpad.net/~lmlogiudice/ubuntu/+source/ceph/+git/ceph/+merge/499546
  Link to PPA used for verification: https://launchpad.net/~lmlogiudice/+archive/ubuntu/ceph-tentacle
  https://launchpad.net/~lmlogiudice/+archive/ubuntu/ceph-tentacle-resolute

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2139385/+subscriptions