[Bug 2061701] Fix merged to nova (unmaintained/2024.1)

[OpenStack Infra]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/982255
Committed: https://opendev.org/openstack/nova/commit/d6cdd73c980b31080710f9a8cf10d7c779780c43
Submitter: "Zuul (22348)"
Branch:    unmaintained/2024.1

commit d6cdd73c980b31080710f9a8cf10d7c779780c43
Author: melanie witt <melwittt at gmail.com>
Date:   Wed Apr 16 15:20:23 2025 -0700

    libvirt: Use common naming convention for ephemeral disk labels
    
    The _create_ephemeral() method is responsible for creating ephemeral
    disks with image type "raw" and formatting them with mkfs. In the case
    of [libvirt]images_type "qcow2", _create_ephemeral() will create
    backing files.
    
    Currently we are not using a consistent naming convention for choosing
    the filesystem label for ephemeral disks. When we create a server for
    example, we go through the disks and label them "ephemeral0",
    "ephemeral1", "ephemeral2", etc.
    
    When we hard reboot a server, there is a check to create missing
    backing files and if so, a new backing file will be created but instead
    of being labeled "ephemeralN" the code attempts to label them with the
    name of the backing file itself for example "ephemeral_1_40d1d2c". This
    will fail if the filesystem used for ephemeral disks has limitations on
    the length of filesystem label names (VFAT, XFS, ...). For example:
    
      mkfs.vfat: Label can be no longer than 11 characters
    
    This adds a helper method for obtaining ephemeral disks filesystem
    label names and uses it the same way in the few places fs_label is
    specified.
    
    Closes-Bug: #2061701
    
    Change-Id: Id033a5760272e4fb06dee2342414b26aa16ffe24
    (cherry picked from commit 82856f95c69bb07bd2a61decae9abe827a2a1567)
    (cherry picked from commit 09fc2fae424493ff9580c6d38e63f207b916529c)
    (cherry picked from commit 2fd65bd14ac33b58e247bf9d3c8066fa5dac2215)
    Signed-off-by: Pierre Riteau <pierre at stackhpc.com>

-- 
You received this bug notification because you are a member of Ubuntu
OpenStack, which is subscribed to Ubuntu Cloud Archive.
https://bugs.launchpad.net/bugs/2061701

Title:
  check_can_live_migrate_source fails with mkfs.vfat error: Label can be
  no longer than 11 characters

Status in Ubuntu Cloud Archive caracal series:
  New
Status in Ubuntu Cloud Archive dalmatian series:
  Won't Fix
Status in Ubuntu Cloud Archive epoxy series:
  New
Status in Ubuntu Cloud Archive flamingo series:
  Fix Released
Status in Ubuntu Cloud Archive gazpacho series:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in nova package in Ubuntu:
  New
Status in nova source package in Noble:
  New

Bug description:
  When testing NBD TLS live-migration the initial attempt failed. Looks
  like a generated filesystem label is too long.

  Subsequent attempts succeeded

  $ nova-compute --version
  Modules with known eventlet monkey patching issues were imported prior to eventlet monkey patching: urllib3. This warning can usually be ignored if the caller is only importing and not executing nova code.
  27.2.1

  oslo_messaging.rpc.client.RemoteError: Remote error: ProcessExecutionError Unexpected error while running command.
  Command: mkfs -t vfat -n ephemeral_1_0706d66 /var/lib/nova/instances/_base/ephemeral_1_0706d66
  Exit code: 1
  Stdout: 'mkfs.fat 4.2 (2021-01-31)\n'
  Stderr: 'mkfs.vfat: Label can be no longer than 11 characters\n'

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/caracal/+bug/2061701/+subscriptions