[Bug 1541457] Re: [Ubuntu 16.04] New package libcxl user space library for CAPI

Mathieu Trudel-Lapierre mathieu.tl at gmail.com
Wed Mar 16 15:03:55 UTC 2016


-> make VERS_SONAME=$(VERS_SONAME) VERS_LIB=$(VERS_LIB)
That should be fixed upstream; "make && make install" should Just Work, as otherwise distros might be tempted to declare any SOVER they want, and it might not be right.

<infinity> cyphermox: So, other than all the above rant, the one thing I might insist on changing would be that they set the VER/SOVER to 0.3/0 until upstream actually bakes a proper SONAME in and agrees to track ABI properly.
<infinity> cyphermox: Cause SOVER 1 implies tracking and consistency across distros, and if we have to set it externally, I don't see how we can promise that.

-> debian/outfile
Probably should be removed. It seems to be a copy of debian/source/format.

-> debian/copyright
If debian/ must be GPL-2+, then debian/patches/* should probably be Apache-2.0; so as to maintain a consistent licensing between the patches and source code. Otherwise, feel free to just have everything licensed Apache-2.0.

-> debian/rules
As above, making sure "make && make install" upstream works correctly should allow simplifying the debian/rules file a lot.

-- 
You received this bug notification because you are a member of Ubuntu
Review Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1541457

Title:
  [Ubuntu 16.04] New package libcxl  user space library for CAPI

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1541457/+subscriptions



More information about the Ubuntu-patch-reviews mailing list