[Merge] lp:~jderose/ubuntu/saucy/couchdb/1.4.0 into lp:ubuntu/couchdb

Chad Miller chad.miller at canonical.com
Wed Aug 28 18:27:26 UTC 2013


Review: Needs Fixing

So nice.  $ bzr diff -r72.. debian/

1)
+XSBC-Original-Maintainer: Jason Gerard DeRose <jason at system76.com>
This should be whoever owned the package in the previous packaging, which usually means the Debian maintainer, but can sometimes be the previous person in Ubuntu.  It shouldn't be whoever's in the changelog.

2)
-case $1 in
-    configure)
-        if dpkg --compare-versions "$2" lt-nl 1.2.0-2ubuntu1; then
Should you be dropping this?  Someone could go from 1.1 to 1.4.

3)
-get-orig-source:
-       uscan --force-download --rename --download-version=$(DEB_UPSTREAM_VERSION) --destdir .
This rule can be useful. In fact, I'd update it so that it uses the most recent standard: Rule should be
"get-packaged-orig-source", and it inherits ORIG_PACKAGE and ORIG_VERSION as Make/environment variables, so it should download orig sources, clean them up, and make a tarball in the current dir that extracts correctly (tar xf ORIG_PACKAGE+"_"+ORIG_SOURCE+".orig.tar.gz"  ->  "./"+ORIG_PACKAGE+"-"+ORIG_VERSION).  This assumes you know where the official tarball or sources will be at release.
-- 
https://code.launchpad.net/~jderose/ubuntu/saucy/couchdb/1.4.0/+merge/182725
Your team Ubuntu branches is requested to review the proposed merge of lp:~jderose/ubuntu/saucy/couchdb/1.4.0 into lp:ubuntu/couchdb.



More information about the Ubuntu-reviews mailing list