[Merge] lp:~kai-mast/friends/fetch-twitter-images into lp:friends

Robert Bruce Park robert.park at canonical.com
Tue Dec 3 18:07:21 UTC 2013


Please specify a default value for picture because python's None value i don't think will work. So:

  picture = url.get('media_url', '')

Oh and please add a test for this as well (look at the existing tests, you might have to add some extra json if there isn't already a media_url key present in the example data).
-- 
https://code.launchpad.net/~kai-mast/friends/fetch-twitter-images/+merge/197556
Your team Super Friends is subscribed to branch lp:friends.



More information about the Ubuntu-reviews mailing list