[Merge] lp:~seb128/apturl/dont-decode-str into lp:apturl

Steve Langasek steve.langasek at canonical.com
Fri Dec 6 18:47:03 UTC 2013


Review: Approve

This looks right to me.  The url always comes to us from optparse, which should always return a Unicode string in python3 already - so there's no need to decode it.

Note that actual use of unicode in the args to apturl-gtk fails, but that's not the original bug that was reported, and not a likely scenario so we don't really need to fix that here.  (Actually, the backtrace in that case appears to be in python-gi/gtk anyway...)
-- 
https://code.launchpad.net/~seb128/apturl/dont-decode-str/+merge/197804
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~seb128/apturl/dont-decode-str into lp:apturl.



More information about the Ubuntu-reviews mailing list