[Merge] lp:~brunonova/software-properties/remove-unnecessary-line into lp:software-properties
Bruno Nova
brunomb.nova at gmail.com
Mon Dec 9 23:27:29 UTC 2013
Bruno Nova has proposed merging lp:~brunonova/software-properties/remove-unnecessary-line into lp:software-properties.
Requested reviews:
Ubuntu Core Development Team (ubuntu-core-dev)
For more details, see:
https://code.launchpad.net/~brunonova/software-properties/remove-unnecessary-line/+merge/198325
The line "self.modified_sourceslist = True" that I added in method on_config_modified() in SoftwarePropertiesGtk.py (merged in commit 881) is not needed, so I'm removing it in this commit.
The impact of that line was minimal: the combo boxes in the "Updates" tab have no effect on the sources list, but changing their values (and nothing else) would make the dialog asking for the apt cache to be reloaded appear when closing the window, and there's no need for that (I guess).
I tested changing the other options in the first 3 tabs, and they all still made the "apt reload" dialog appear correctly on close.
--
https://code.launchpad.net/~brunonova/software-properties/remove-unnecessary-line/+merge/198325
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~brunonova/software-properties/remove-unnecessary-line into lp:software-properties.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 552 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20131209/b4e06a1c/attachment.diff>
More information about the Ubuntu-reviews
mailing list