[Merge] lp:~darkxst/ubuntu/trusty/gnome-documents/gir-fix into lp:ubuntu/gnome-documents

Dmitry Shachnev mitya57 at gmail.com
Sun Dec 22 08:22:57 UTC 2013


Review: Needs Information

Thanks for your work here.

1) Shouldn’t that be ‘girepository’ instead of ‘gir’? Did you actually verify the fix?

2) Currently the package fails to build on armhf:

 /usr/bin/install -c -m 644 gnome-documents.gresource '/build/buildd/gnome-documents-3.10.0/debian/gnome-documents/usr/share/gnome-documents'
/usr/bin/install: cannot change permissions of '/build/buildd/gnome-documents-3.10.0/debian/gnome-documents/usr/share/gnome-documents/js/path.js': No such file or directory

You should fix that, otherwise it won’t migrate from proposed to release.
-- 
https://code.launchpad.net/~darkxst/ubuntu/trusty/gnome-documents/gir-fix/+merge/199888
Your team Ubuntu branches is requested to review the proposed merge of lp:~darkxst/ubuntu/trusty/gnome-documents/gir-fix into lp:ubuntu/gnome-documents.



More information about the Ubuntu-reviews mailing list