[Merge] lp:~mterry/update-notifier/pkexec into lp:update-notifier

Colin Watson cjwatson at canonical.com
Thu Jan 31 23:58:20 UTC 2013


> -GKSU = ["/usr/bin/gksu"]
> -SYNPATIC_DESKTOP = ["--desktop", 
> -                    "/usr/share/applications/synaptic.desktop", 
> -                    "--"]
> +SUDO = ["/usr/bin/pkexec"]

If you're renaming the variable, call it PKEXEC, please, or at least
something that isn't the name of another tool.  It's rather confusing
otherwise.

> === modified file 'data/cddistupgrader'
> --- data/cddistupgrader	2013-01-31 14:13:55 +0000
> +++ data/cddistupgrader	2013-01-31 23:13:25 +0000
> @@ -28,4 +28,4 @@
>  done
>  
>  # run it
> -gksu -- "$TMPDIR"/"$CODENAME" --cdrom "$CDROM_MOUNT"
> +pkexec "$TMPDIR"/"$CODENAME" --cdrom "$CDROM_MOUNT"

I don't think this works for cddistupgrader, because the upgrader is
going to want to talk to the X server and pkexec doesn't allow that by
default.

I was considering shipping a polkit action file for cddistupgrader
itself and executing the whole lot under pkexec, which might be simpler
to arrange ...

-- 
https://code.launchpad.net/~mterry/update-notifier/pkexec/+merge/146003
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~mterry/update-notifier/pkexec into lp:update-notifier.



More information about the Ubuntu-reviews mailing list