[Merge] lp:~robru/friends/simplify-contacts into lp:friends
Robert Bruce Park
robert.park at canonical.com
Sat Jul 20 03:37:25 UTC 2013
Robert Bruce Park has proposed merging lp:~robru/friends/simplify-contacts into lp:friends.
Commit message:
Vast simplification of contact logic.
Requested reviews:
Super Friends (super-friends)
For more details, see:
https://code.launchpad.net/~robru/friends/simplify-contacts/+merge/175968
Great simplification of our messy contacts implementation. Lots of big changes here, but here are some highlights:
* Stop creating VCards, serializing them into strings, and then parsing them back into EDS Contact objects. Just create the Contact directly.
* Stop iterating over all EDS address books, looking for the one with the right display name. Simply request the correct address book by ID the first time. Also cache this instance through the lifetime of the script, so it doesn't need to be polled for continuously.
* Streamline a lot of the _create_contact logic, which was highly reminiscent of the old Gwibber code, where json-ish data structures were being schlepped around and copied from one form into another, for no apparent reason.
--
https://code.launchpad.net/~robru/friends/simplify-contacts/+merge/175968
Your team Super Friends is requested to review the proposed merge of lp:~robru/friends/simplify-contacts into lp:friends.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 53875 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20130720/da5b60e4/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list