[Merge] lp:~mfisch/ubuntu/saucy/ubuntu-touch-customization-hooks/add-scripts into lp:ubuntu/ubuntu-touch-customization-hooks

Loïc Minier lool at dooz.org
Wed Sep 11 16:54:08 UTC 2013


Looks much better now!

Two small things:

1) /custom/etc/dconf/.updated => this will only happen once on the first boot, and then never again; why can't we pregenerate this in the image?  dont you want to run this when custom.tgz is updated?  Or perhaps you plan to remove the flag from the upgrade scripts once we have this support?

2) I'm assuming you have some kind of server-side machinery that will prevent promotion of new base ubuntu.tgz when /etc/dconf/* changes in it, as for you to integrate the changes?

otherwise looks good.

PS: instead of "address review comment", best to list actual changes of the commit since the merge proposal wont be easily discoverable to people reading the bzr history later on (and it's one less indirection)
-- 
https://code.launchpad.net/~mfisch/ubuntu/saucy/ubuntu-touch-customization-hooks/add-scripts/+merge/184880
Your team Ubuntu Development Team is requested to review the proposed merge of lp:~mfisch/ubuntu/saucy/ubuntu-touch-customization-hooks/add-scripts into lp:ubuntu/ubuntu-touch-customization-hooks.



More information about the Ubuntu-reviews mailing list