[Merge] lp:~gerboland/qtubuntu/fix_1351024 into lp:qtubuntu

Gerry Boland gerry.boland at canonical.com
Fri Aug 8 14:08:25 UTC 2014


Shouldn't we deduct panelHeight from the geometry.height?
Ie, it's either

(0, 0, screenWidth, screenHeight) or (0, panelHeight, screenWidth, screenHeight - panelHeight),
but here it seems you're setting it to (0, panelHeight, screenWidth, screenHeight), which is wrong


I disagree. The client is asking for a surface with a particular geometry, we should not shrink it. Shell is the one which decides to shrink it anyway
-- 
https://code.launchpad.net/~gerboland/qtubuntu/fix_1351024/+merge/230094
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list