[Merge] lp:~renatofilho/address-book-service/change-upstart-rule into lp:address-book-service
Bill Filler
bill.filler at canonical.com
Tue Aug 19 03:20:04 UTC 2014
Diff comments:
> === modified file 'upstart/address-book-service.conf'
> --- upstart/address-book-service.conf 2013-07-17 20:53:00 +0000
> +++ upstart/address-book-service.conf 2014-08-18 21:44:14 +0000
> @@ -2,8 +2,10 @@
> author "Bill Filler <bill.filler at canonical.com>"
>
> start on started unity8
> -stop on session-end
> +stop on desktop-end
>
why the change to desktop-end?
> respawn
>
> exec /usr/lib/arm-linux-gnueabihf/address-book-service/address-book-service
> +
> +post-start exec /usr/lib/evolution/evolution-addressbook-factory
shouldn't we use pre-start or add an exec before the address-book-service exec? using post-start won't start evolution until after address-book-service and I thought we wanted it to be running before?
>
--
https://code.launchpad.net/~renatofilho/address-book-service/change-upstart-rule/+merge/231268
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~renatofilho/address-book-service/change-upstart-rule into lp:address-book-service.
More information about the Ubuntu-reviews
mailing list