[Merge] lp:~phablet-team/ofono/ofono-update into lp:~phablet-team/ofono/ubuntu

[Tony Espy]

Review: Needs Fixing

The merge itself looks correct, however a few things need fixing:

1. Even though it's somewhat redundant, a description should always be set.  In fact, I should've mentioned that the commit message in the MP can be set to "see debian/changelog", as the provided changelog will be used.

2. The formatting of the debian/changelog needs fixing.  Please take a look at the previous changelog entry to see what I mean.  At minimum, individual authors need to be attributed to the changes via "[]".  Also, you might see if some of the lines could be shortened, as it looks odd that all of the changes wrap and have the bug numbers on the next line.

3. Finally, in general, it's not great practice to include private bugs in changes ( see LP: #1352339 ).  In general, a better approach is to open public bugs that can be referenced by the private bug, and include the public bug in the changelog.  In this case, if you can't make the bug public, you're probably just better off removing the private bug # from the changelog and closing the bug manually.
-- 
https://code.launchpad.net/~phablet-team/ofono/ofono-update/+merge/231422
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/ofono/ubuntu.