[Merge] lp:~artmello/gallery-app/gallery-app-new_header into lp:gallery-app
Leo Arias
leo.arias at canonical.com
Thu Aug 28 17:50:08 UTC 2014
Review: Needs Fixing
The issue on this branch is that the pick mode is no longer showing the label.
To reproduce, build it and:
./src/gallery-app --pick-mode
You can see on this video that we are trying to click outside of the app, probably because the label's globalRect points to that place:
https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2577/artifact/results/autopilot/artifacts/gallery_app.tests.test_picker_mode.TestPickerMode.test_pick_named_photo.ogv
All the tests that follow will fail because this one left the unity dash open. We could try to fail more elegantly, like raise an exception if we are trying to click a label that's not visible. I'll see if I can reproduce this case with a simple script and propose a fix with a regression test on the toolkit.
--
https://code.launchpad.net/~artmello/gallery-app/gallery-app-new_header/+merge/231601
Your team Ubuntu Phablet Team is subscribed to branch lp:gallery-app.
More information about the Ubuntu-reviews
mailing list